Repository navigation
Conversation
- tests/notification/duplicates_test.php: the same update handed over by the cron job repeatedly yields exactly one notification per user, a newer version a new one - tests/notification/base.php: provide a fresh type instance per request like shared: false - notification/base.php: parent::create_insert_array() has no return value since phpBB 3.2 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CFCEXHKUor1WeKS7KibQwV
This was referenced Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zusammenfassung
Ergebnis der Issue-Durchsicht nach dem 3.3-Port (#18): Ein Regressionstest für das Verhalten aus #13 und #6 sowie eine kleine Aufräumung aus #3.
tests/notification/duplicates_test.php: Der Cron-Job übergibt bei jedem Lauf dieselben Daten. Der Test prüft über den echten Notification-Manager, dass dabei pro Benutzer genau eine Benachrichtigung entsteht und eine neuere Version eine neue auslöst.tests/notification/base.php: liefert pro Anfrage eine neue Typ-Instanz (wieshared: falseinservices.yml); ohne das teilen sich alle Benutzer eine Instanz.notification/base.php:parent::create_insert_array()hat seit phpBB 3.2 keinen Rückgabewert mehr, dasreturnentfällt.Status der offenen Issues
language,find_users_for_notification,create_insert_array) – kann geschlossen werdenname+ extrahierter Version berechnet und ist bei gleichen Daten stabil; der neue Test belegt das – kann geschlossen werdena_extensionsbzw.a_board(plus Gründer)check_ext_versions()kann es, der Cron nutzt aber die Standardwerte, es fehlt eine EinstellungTests
35 Tests / 161 Assertions grün (MariaDB, PHP 8.3, CI-Konfiguration inkl. funktionaler Tests); Code Sniffer sauber.
Generated by Claude Code