impl(bq_driver): add SQLStatistics api integration test case - #1647
Draft
NeerajDwivedii wants to merge 1 commit into
Draft
impl(bq_driver): add SQLStatistics api integration test case#1647NeerajDwivedii wants to merge 1 commit into
NeerajDwivedii wants to merge 1 commit into
Conversation
NeerajDwivedii
force-pushed
the
add_SQLStatics_integ_tests
branch
from
August 31, 2026 08:30
ca34889 to
26bffa0
Compare
NeerajDwivedii
changed the title
| EXPECT_EQ(Disconnect(conn), SQL_SUCCESS); | ||
|
|
||
| EXPECT_EQ(Connect(kDefaultConnectionString, conn), SQL_SUCCESS); | ||
| auto status = SQLStatistics( |
Collaborator
There was a problem hiding this comment.
where are we checking the values given by the API?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds integration test cases for the
SQLStatisticsAPI, covering all major scenarios. Here is design doc https://docs.google.com/document/d/1K0cItDJfEQuniZ3x4jaT1rf-Tcv8mnPNzcxpcy-UlG0/edit?tab=t.0#heading=h.9zi49wdkb4b1