Skip to content

impl(bq_driver): add SQLStatistics api integration test case #1647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NeerajDwivedii wants to merge 2 commits into
base: main
Choose a base branch
from
Open

impl(bq_driver): add SQLStatistics api integration test case #1647

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26bffa0
impl(bq_driver): add SQLStatistics api integration test case
NeerajDwivedii Aug 31, 2026
24ce6ec
add new chnage
NeerajDwivedii Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
162 changes: 161 additions & 1 deletion google/cloud/odbc/integration_tests/odbc_driver_tests/catalog_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2135,7 +2135,7 @@ TEST(SQLColumns, Check_SQLColumnsDescriptors) {
TEST(SQLTables, Check_SQLTablesDescriptors) {
auto conn = std::make_shared<ODBCHandles>();
EXPECT_EQ(Connect(kDefaultConnectionString, conn), SQL_SUCCESS);
SQLRETURN status =
auto status =
SQLTables(conn->hstmt, (SQLCHAR*)SQL_ALL_CATALOGS, SQL_NTS,
(SQLCHAR*)kNullString.c_str(), 0, (SQLCHAR*)kNullString.c_str(),
0, (SQLCHAR*)kNullString.c_str(), 0);
Expand Down Expand Up @@ -2215,4 +2215,164 @@ TEST(CatalogTest, SQLTables_NullCatalogFiltersToCurrentProject) {
EXPECT_EQ(Disconnect(conn), SQL_SUCCESS);
}

#ifndef BQ_DRIVER_INTEGRATION_TESTS
TEST(CatalogTest, SQLStatistics_ValidTableRows) {
auto conn = std::make_shared<ODBCHandles>();
std::string table_name = kDatasetWithTablePrefix + "ODBC_SQLSTATISTICS_TEST";

// Create table
EXPECT_EQ(Connect(kDefaultConnectionString, conn), SQL_SUCCESS);
Table table(table_name);
table.CreateWithPrepare(conn, "(StringField STRING)");
EXPECT_EQ(Disconnect(conn), SQL_SUCCESS);

EXPECT_EQ(Connect(kDefaultConnectionString, conn), SQL_SUCCESS);
auto status = SQLStatistics(

@shivamd-gpartner shivamd-gpartner Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where are we checking the values given by the API?

@NeerajDwivedii NeerajDwivedii Sep 1, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, added changes

conn->hstmt, nullptr, 0, // Catalog
nullptr, 0, // Schema
reinterpret_cast<SQLCHAR*>(const_cast<char*>(table_name.c_str())),
SQL_NTS, // Table
SQL_INDEX_ALL, SQL_QUICK);
CheckError(status, "SQLStatistics", conn);
ASSERT_TRUE(status == SQL_SUCCESS || status == SQL_SUCCESS_WITH_INFO);

// Verify expected ODBC result-set schema
SQLSMALLINT column_count = 0;
status = SQLNumResultCols(conn->hstmt, &column_count);
CheckError(status, "SQLNumResultCols", conn);
EXPECT_EQ(SQL_SUCCESS, status);
EXPECT_EQ(13, column_count);

// Verify result-set column names.
std::vector<std::string> const expected_column_names = {
"TABLE_CAT", "TABLE_SCHEM", "TABLE_NAME", "NON_UNIQUE",
"INDEX_QUALIFIER", "INDEX_NAME", "TYPE", "ORDINAL_POSITION",
"COLUMN_NAME", "ASC_OR_DESC", "CARDINALITY", "PAGES",
"FILTER_CONDITION"};

for (SQLUSMALLINT column = 1; column <= column_count; ++column) {
SQLCHAR column_name[256] = {};
SQLSMALLINT column_name_length = 0;
SQLSMALLINT data_type = 0;
SQLULEN column_size = 0;
SQLSMALLINT decimal_digits = 0;
SQLSMALLINT nullable = 0;
status =
SQLDescribeCol(conn->hstmt, column, column_name, sizeof(column_name),
&column_name_length, &data_type, &column_size,
&decimal_digits, &nullable);
ASSERT_TRUE(status == SQL_SUCCESS || status == SQL_SUCCESS_WITH_INFO);
std::string actual_column_name(reinterpret_cast<char*>(column_name),
column_name_length);
EXPECT_EQ(expected_column_names[column - 1], actual_column_name)
<< "Unexpected column name at column " << column;
}

// Verify that the result set
SQLINTEGER row_count = 0;
while (true) {
status = SQLFetch(conn->hstmt);
if (status == SQL_NO_DATA) {
break;
}
ASSERT_TRUE(status == SQL_SUCCESS || status == SQL_SUCCESS_WITH_INFO);
++row_count;
}
EXPECT_GE(row_count, 0);

EXPECT_EQ(Disconnect(conn), SQL_SUCCESS);

// Drop table
EXPECT_EQ(Connect(kDefaultConnectionString, conn), SQL_SUCCESS);
table.DropWithPrepare(conn);
EXPECT_EQ(Disconnect(conn), SQL_SUCCESS);
}

TEST(CatalogTest, SQLStatistics_IndexUnique) {
auto conn = std::make_shared<ODBCHandles>();
std::string table_name =
kDatasetWithTablePrefix + "ODBC_SQLSTATISTICS_INDEXUNIQUE_TEST";
// Create table
EXPECT_EQ(Connect(kDefaultConnectionString, conn), SQL_SUCCESS);
Table table(table_name);
table.CreateWithPrepare(conn, "(StringField STRING)");
EXPECT_EQ(Disconnect(conn), SQL_SUCCESS);

EXPECT_EQ(Connect(kDefaultConnectionString, conn), SQL_SUCCESS);
auto status = SQLStatistics(
conn->hstmt, nullptr, 0, nullptr, 0,
reinterpret_cast<SQLCHAR*>(const_cast<char*>(table_name.c_str())),
SQL_NTS, SQL_INDEX_ALL, SQL_QUICK);

ASSERT_TRUE(status == SQL_SUCCESS || status == SQL_SUCCESS_WITH_INFO);
EXPECT_EQ(Disconnect(conn), SQL_SUCCESS);
// Drop table
EXPECT_EQ(Connect(kDefaultConnectionString, conn), SQL_SUCCESS);
table.DropWithPrepare(conn);
EXPECT_EQ(Disconnect(conn), SQL_SUCCESS);
}

TEST(CatalogTest, SQLStatistics_NonExistentTable) {
auto conn = std::make_shared<ODBCHandles>();
EXPECT_EQ(Connect(kDefaultConnectionString, conn), SQL_SUCCESS);

auto status = SQLStatistics(conn->hstmt, nullptr, 0, nullptr, 0,
reinterpret_cast<SQLCHAR*>(const_cast<char*>(
"table_that_does_not_exist")),
SQL_NTS, SQL_INDEX_ALL, SQL_QUICK);
EXPECT_EQ(status, SQL_SUCCESS);

if (status == SQL_SUCCESS || status == SQL_SUCCESS_WITH_INFO) {
EXPECT_EQ(SQL_NO_DATA, SQLFetch(conn->hstmt));
}
EXPECT_EQ(Disconnect(conn), SQL_SUCCESS);
}

TEST(CatalogTest, SQLStatistics_NullAndEmptyTable) {
auto conn = std::make_shared<ODBCHandles>();
EXPECT_EQ(Connect(kDefaultConnectionString, conn), SQL_SUCCESS);

// Null Table
auto status = SQLStatistics(conn->hstmt, nullptr, 0, nullptr, 0, nullptr, 0,
SQL_INDEX_ALL, SQL_QUICK);

EXPECT_EQ(SQL_ERROR, status);

// Empty table
char const table_name[] = "";
status =
SQLStatistics(conn->hstmt, nullptr, 0, nullptr, 0,
reinterpret_cast<SQLCHAR*>(const_cast<char*>(table_name)),
SQL_NTS, SQL_INDEX_ALL, SQL_QUICK);

EXPECT_EQ(SQL_SUCCESS, status);
EXPECT_EQ(Disconnect(conn), SQL_SUCCESS);
}

TEST(CatalogTest, SQLStatisticsW_ValidTable) {
auto conn = std::make_shared<ODBCHandles>();
std::string table_name = kDatasetWithTablePrefix + "ODBC_SQLSTATISTICSW_TEST";

// Create table
EXPECT_EQ(Connect(kDefaultConnectionString, conn), SQL_SUCCESS);
Table table(table_name);
table.CreateWithPrepare(conn, "(StringField STRING)");
EXPECT_EQ(Disconnect(conn), SQL_SUCCESS);

EXPECT_EQ(Connect(kDefaultConnectionString, conn), SQL_SUCCESS);
auto status = SQLStatistics(
conn->hstmt, nullptr, 0, // Catalog
nullptr, 0, // Schema
reinterpret_cast<SQLCHAR*>(const_cast<char*>(table_name.c_str())),
SQL_NTS, // Table
SQL_INDEX_ALL, SQL_QUICK);
ASSERT_TRUE(status == SQL_SUCCESS || status == SQL_SUCCESS_WITH_INFO);
EXPECT_EQ(Disconnect(conn), SQL_SUCCESS);

// Drop table
EXPECT_EQ(Connect(kDefaultConnectionString, conn), SQL_SUCCESS);
table.DropWithPrepare(conn);
EXPECT_EQ(Disconnect(conn), SQL_SUCCESS);
}
#endif // BQ_DRIVER_INTEGRATION_TESTS
} // namespace google::cloud::odbc_tests
Loading