Repository navigation
Conversation
Coverage (unit tests)No unit baseline recorded in
Line and branch coverage from unit test reports. History is recorded in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
x-release-please-start-versionblocks in the READMEs and skills wrap whole code snippets, and some of those snippets also pin other libraries. release-please's generic updater replaces everyx.y.zversion inside a block, so the closed release PR #4 would have shipped docs telling users to addtruth = "1.1.0-rc01",kotlin = "1.1.0-rc01"andcom.google.truth:truth:1.1.0-rc01.The four
compatibility:lines in the skills' front matter had no marker at all, so they were never bumped and would have kept saying1.0.0-rc01+.Changes:
x-release-please-versioncomment, since HTML comments cannot go inside a code fence. Blocks that contain only our versions are unchanged.compatibility:lines get an inline marker as a YAML comment. The inline marker only replaces the first version on its line, so the umbrella skill now states the version once instead of three times.To check it, I ran release-please's own
Genericupdater (release-please 17) over everyextra-filesentry with a1.1.0-rc01bump:main: 6 foreign versions rewritten (the ones from chore(main): release 1.1.0-rc01 #4) and 4 lines left at1.0.0-rc01.1.0.0-rc01left behind.Docs and config only, so I did not run the Gradle checks.