Skip to content

fix: limit release-please version updates to this library's versions - #6

Open
kikoso wants to merge 1 commit into
mainfrom
fix/release-please-version-markers
Open

kikoso wants to merge 1 commit into
mainfrom
fix/release-please-version-markers

Conversation

@kikoso

@kikoso kikoso commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator

The x-release-please-start-version blocks in the READMEs and skills wrap whole code snippets, and some of those snippets also pin other libraries. release-please's generic updater replaces every x.y.z version inside a block, so the closed release PR #4 would have shipped docs telling users to add truth = "1.1.0-rc01", kotlin = "1.1.0-rc01" and com.google.truth:truth:1.1.0-rc01.

The four compatibility: lines in the skills' front matter had no marker at all, so they were never bumped and would have kept saying 1.0.0-rc01+.

Changes:

  • The four blocks that also contain another library's version (root README toml, robolectric README toml and Gradle snippets, umbrella skill toml, robolectric skill Gradle snippet) drop the block markers. Only our own version lines get an inline x-release-please-version comment, since HTML comments cannot go inside a code fence. Blocks that contain only our versions are unchanged.
  • The skills' compatibility: lines get an inline marker as a YAML comment. The inline marker only replaces the first version on its line, so the umbrella skill now states the version once instead of three times.

To check it, I ran release-please's own Generic updater (release-please 17) over every extra-files entry with a 1.1.0-rc01 bump:

  • main: 6 foreign versions rewritten (the ones from chore(main): release 1.1.0-rc01 #4) and 4 lines left at 1.0.0-rc01.
  • This branch: 22 lines bumped, all of them ours, nothing foreign touched, no 1.0.0-rc01 left behind.

Docs and config only, so I did not run the Gradle checks.

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

Coverage (unit tests)

No unit baseline recorded in coverage/history.csv yet, so this run only reports absolute numbers.

Module Line % Change Branch % Change
golden-testing 90.42% new 58.00% new
robolectric-testing 84.06% new 51.87% new
visual-testing 36.54% new 25.07% new
TOTAL 78.88% new 44.10% new

Line and branch coverage from unit test reports. History is recorded in coverage/history.csv after each merge to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants