Repository navigation
Conversation
Coverage (unit tests)No unit baseline recorded in
Line and branch coverage from unit test reports. History is recorded in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gradle.propertiesis committed with emptymavenCentralUsername=,mavenCentralPassword=andsigning.*=entries, which the publish workflow fills in withsed. Empty secret slots in a tracked file make it easy for someone publishing locally to fill them in and commit them by accident.gradle.properties: the five placeholders are replaced with a comment pointing to~/.gradle/gradle.propertiesorORG_GRADLE_PROJECT_*variables.publish.yml: the step now appends the five properties withprintfinstead ofsed-replacing the placeholders. It is still the same file in the CI workspace, and the property names and secrets haven't changed.This also fixes a latent bug: the old step only escaped the Sonatype password. A GPG key ID or password containing
,or&would have broken thesedexpression or written a wrong value.printf '%s'writes the values as is. I ran the new step locally with values containing,&and/and the output is correct.Also checked:
./gradlew publishToMavenLocalstill configures and builds all three AARs with no credentials set (signing is skipped as before). I could not run the real publish job.