Skip to content

build: stop keeping credential placeholders in gradle.properties #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kikoso wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: stop keeping credential placeholders in gradle.properties #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,14 @@ jobs:
gpg --quiet --output $GITHUB_WORKSPACE/release.gpg --dearmor ./release.asc

echo "Build and publish"
sed -i -e "s,mavenCentralUsername=,mavenCentralUsername=$SONATYPE_TOKEN_USERNAME,g" gradle.properties
SONATYPE_TOKEN_PASSWORD_ESCAPED=$(printf '%s\n' "$SONATYPE_TOKEN_PASSWORD" | sed -e 's/[\/&]/\\&/g')
sed -i -e "s,mavenCentralPassword=,mavenCentralPassword=$SONATYPE_TOKEN_PASSWORD_ESCAPED,g" gradle.properties
sed -i -e "s,signing.keyId=,signing.keyId=$GPG_KEY_ID,g" gradle.properties
sed -i -e "s,signing.password=,signing.password=$GPG_PASSWORD,g" gradle.properties
sed -i -e "s,signing.secretKeyRingFile=,signing.secretKeyRingFile=$GITHUB_WORKSPACE/release.gpg,g" gradle.properties
{
echo
printf 'mavenCentralUsername=%s\n' "$SONATYPE_TOKEN_USERNAME"
printf 'mavenCentralPassword=%s\n' "$SONATYPE_TOKEN_PASSWORD"
printf 'signing.keyId=%s\n' "$GPG_KEY_ID"
printf 'signing.password=%s\n' "$GPG_PASSWORD"
printf 'signing.secretKeyRingFile=%s\n' "$GITHUB_WORKSPACE/release.gpg"
} >> gradle.properties
env:
GPG_KEY_ARMOR: ${{ secrets.SYNCED_GPG_KEY_ARMOR }}
GPG_KEY_ID: ${{ secrets.SYNCED_GPG_KEY_ID }}
Expand Down
9 changes: 3 additions & 6 deletions gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,9 @@ android.useAndroidX=true
# Kotlin code style for this project: "official" or "obsolete":
kotlin.code.style=official

mavenCentralUsername=
mavenCentralPassword=

signing.keyId=
signing.password=
signing.secretKeyRingFile=
# Maven Central and signing credentials are not set here. Pass them through
# ~/.gradle/gradle.properties or ORG_GRADLE_PROJECT_* environment variables;
# the publish workflow appends them in CI.

# Enables namespacing of each library's R class so that its R class includes only the
# resources declared in the library itself and none from the library's dependencies,
Expand Down
Loading