chore(deps): bump hotdata SDK to 0.19.0 - #317
Merged
Merged
Conversation
0.19.0 makes constant_per_key a required field on TableInfo. The server already sends it, so this updates the hand-written table-listing test fixtures to match. ForkDatabaseRequest gains a description field, which the CLI leaves unset for now.
shefeek-jinnah
requested review from
zfarrell
and removed request for
a team
September 23, 2026 11:43
5 tasks
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| hotdata::models::ForkDatabaseRequest { | ||
| name: name.map(Some), | ||
| expires_at: expires_at.map(|e| Some(e.to_string())), | ||
| description: None, |
Contributor
There was a problem hiding this comment.
super nit: the comment above at line 882 says "both fields", but the struct literal now sets three fields. Update the wording to cover description so the double-option note stays accurate. (not blocking)
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the
hotdataSDK from 0.18.1 to 0.19.0. This PR changes no CLI behavior.constant_per_keya required field onTableInfo. The server has sent it since runtimedb #1300 (Sept 3), but the CLI's hand-written table-listing fixtures didn't, so they are updated to match.ForkDatabaseRequest: it has a newdescriptionfield. The CLI leaves it unset (None) here. feat(databases): record why a fork was taken #315 adds the--descriptionflag that sets it.#315 builds on this PR.
Test plan
cargo test: 596 passedcargo clippy --all-targets -- -D warningsandcargo fmt --check