Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ path = "src/main.rs"
# behind a shared multi-thread tokio runtime. The `arrow` feature backs result
# decode; `upload_file` runs the presigned direct-to-storage upload flow
# (see src/sdk.rs::Api::upload).
hotdata = { version = "0.18.1", features = ["arrow"] }
hotdata = { version = "0.19.0", features = ["arrow"] }
# Shared multi-thread runtime for the sync wrapper; block_on is called
# concurrently from rayon worker threads (see src/indexes.rs). The presigned
# upload (src/sdk.rs::Api::upload) drives the SDK's async `upload_file` on this
Expand Down
9 changes: 5 additions & 4 deletions src/commands/databases.rs
Original file line number Diff line number Diff line change
Expand Up @@ -885,6 +885,7 @@ pub fn fork_database_request(
hotdata::models::ForkDatabaseRequest {
name: name.map(Some),
expires_at: expires_at.map(|e| Some(e.to_string())),
description: None,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super nit: the comment above at line 882 says "both fields", but the struct literal now sets three fields. Update the wording to cover description so the double-option note stays accurate. (not blocking)

}
}

Expand Down Expand Up @@ -3897,7 +3898,7 @@ mod tests {
.with_status(200)
.with_header("content-type", "application/json")
.with_body(
r#"{"count":1,"limit":1000,"tables":[{"connection":"default","schema":"public","table":"b","synced":true,"partition_by":[],"sorted_by":[],"last_sync":null}],"has_more":false,"next_cursor":null}"#,
r#"{"count":1,"limit":1000,"tables":[{"connection":"default","schema":"public","table":"b","synced":true,"partition_by":[],"sorted_by":[],"constant_per_key":[],"last_sync":null}],"has_more":false,"next_cursor":null}"#,
)
.create();
let page0 = server
Expand All @@ -3909,7 +3910,7 @@ mod tests {
.with_status(200)
.with_header("content-type", "application/json")
.with_body(
r#"{"count":1,"limit":1000,"tables":[{"connection":"default","schema":"public","table":"a","synced":false,"partition_by":[],"sorted_by":[],"last_sync":null}],"has_more":true,"next_cursor":"cur2"}"#,
r#"{"count":1,"limit":1000,"tables":[{"connection":"default","schema":"public","table":"a","synced":false,"partition_by":[],"sorted_by":[],"constant_per_key":[],"last_sync":null}],"has_more":true,"next_cursor":"cur2"}"#,
)
.create();

Expand Down Expand Up @@ -4023,7 +4024,7 @@ mod tests {
.with_status(200)
.with_header("content-type", "application/json")
.with_body(
r#"{"count":1,"limit":5,"tables":[{"connection":"default","schema":"public","table":"a","synced":true,"partition_by":[],"sorted_by":[],"last_sync":null}],"has_more":true,"next_cursor":"page2"}"#,
r#"{"count":1,"limit":5,"tables":[{"connection":"default","schema":"public","table":"a","synced":true,"partition_by":[],"sorted_by":[],"constant_per_key":[],"last_sync":null}],"has_more":true,"next_cursor":"page2"}"#,
)
.expect(1)
.create();
Expand All @@ -4049,7 +4050,7 @@ mod tests {
.with_status(200)
.with_header("content-type", "application/json")
.with_body(
r#"{"count":1,"limit":1000,"tables":[{"connection":"default","schema":"public","table":"orders","synced":true,"partition_by":[],"sorted_by":[],"last_sync":null}],"has_more":false,"next_cursor":null}"#,
r#"{"count":1,"limit":1000,"tables":[{"connection":"default","schema":"public","table":"orders","synced":true,"partition_by":[],"sorted_by":[],"constant_per_key":[],"last_sync":null}],"has_more":false,"next_cursor":null}"#,
)
.create();

Expand Down
12 changes: 6 additions & 6 deletions src/commands/indexes.rs
Original file line number Diff line number Diff line change
Expand Up @@ -766,7 +766,7 @@ mod tests {
.with_header("content-type", "application/json")
.with_body(
r#"{"count":1,"limit":100,"tables":[
{"connection":"__db_abc","schema":"public","table":"vec_mid","synced":true,"partition_by":[],"sorted_by":[]}
{"connection":"__db_abc","schema":"public","table":"vec_mid","synced":true,"partition_by":[],"sorted_by":[],"constant_per_key":[]}
],"has_more":false,"next_cursor":null}"#,
)
.create();
Expand Down Expand Up @@ -848,7 +848,7 @@ mod tests {
.with_header("content-type", "application/json")
.with_body(
r#"{"count":1,"limit":100,"tables":[
{"connection":"__db_abc","schema":"public","table":"listings","synced":true,"partition_by":[],"sorted_by":[]}
{"connection":"__db_abc","schema":"public","table":"listings","synced":true,"partition_by":[],"sorted_by":[],"constant_per_key":[]}
],"has_more":false,"next_cursor":null}"#,
)
.create();
Expand Down Expand Up @@ -903,7 +903,7 @@ mod tests {
.with_header("content-type", "application/json")
.with_body(
r#"{"count":1,"limit":100,"tables":[
{"connection":"Warehouse","schema":"public","table":"events","synced":true,"partition_by":[],"sorted_by":[]}
{"connection":"Warehouse","schema":"public","table":"events","synced":true,"partition_by":[],"sorted_by":[],"constant_per_key":[]}
],"has_more":false,"next_cursor":null}"#,
)
.create();
Expand Down Expand Up @@ -947,7 +947,7 @@ mod tests {
.with_header("content-type", "application/json")
.with_body(
r#"{"count":1,"limit":100,"tables":[
{"connection":"__db_abc","schema":"public","table":"listings","synced":true,"partition_by":[],"sorted_by":[]}
{"connection":"__db_abc","schema":"public","table":"listings","synced":true,"partition_by":[],"sorted_by":[],"constant_per_key":[]}
],"has_more":false,"next_cursor":null}"#,
)
.create();
Expand Down Expand Up @@ -993,8 +993,8 @@ mod tests {
.with_header("content-type", "application/json")
.with_body(
r#"{"count":2,"limit":100,"tables":[
{"connection":"c1","schema":"public","table":"z","synced":true,"partition_by":[],"sorted_by":[]},
{"connection":"c1","schema":"public","table":"a","synced":true,"partition_by":[],"sorted_by":[]}
{"connection":"c1","schema":"public","table":"z","synced":true,"partition_by":[],"sorted_by":[],"constant_per_key":[]},
{"connection":"c1","schema":"public","table":"a","synced":true,"partition_by":[],"sorted_by":[],"constant_per_key":[]}
],"has_more":false,"next_cursor":null}"#,
)
.create();
Expand Down
Loading