fix: clean up closed viewers when transitions are interrupted - #243
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing a viewer can leave an invisible overlay blocking the page when its CSS transition is disabled, interrupted, or never starts. The close path depended entirely on
transitionend.Related to #122. Keep the fade-out, stop intercepting pointer events after closing, and hide the viewer with a fallback based on the computed opacity transition duration and delay. Cancel that fallback on reopen/unmount and accept only the root opacity transition event.
Validation:
npm run verifynow pass, including library/demo/SSR builds, hydration, multipart, package checks, and both critical audit gates.display: noneand successful page hit tests.