fix: clean up owned viewer portal containers - #245
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeatedly mounting and unmounting Viewer leaves an empty div in document.body on each mount. Inline viewers also append an unused body container. Allocate the default portal only when needed, remove it on unmount or a switch to a custom container, and preserve caller-owned containers.
Related to the container-cleanup portion of #158. This change does not add a ref or imperative API, so the broader report remains open.
Validation: all four new regression tests failed before the fix; all 50 tests and
npm run verifypass after it. Chrome 149 reproduced seven accumulating unused divs with npm 3.2.5 across repeated mounts, a never-opened viewer, inline mode, and container switching. The updated build leaves zero extra nodes in every scenario and preserves the custom container. Public-registry scan passed; no dependency or API changes.