fix(dts): bundle ZipSlipGuard into delivery-tier-distribution jar (#65) - #66
Merged
natechadwick merged 1 commit intoAug 24, 2026
Merged
Conversation
MainDTSPreInstall calls com.percussion.security.io.ZipSlipGuard but delivery-tier-distribution declared no dependency on perc-security-utils and its jar was built without bundled dependencies. Running java -jar delivery-tier-distribution.jar at pre-install time then threw NoClassDefFoundError: com/percussion/security/io/ZipSlipGuard. - Declare compile-scope dep on com.percussion:perc-security-utils. - Add maven-assembly-plugin with jar-with-dependencies so the produced jar bundles runtime deps, mirroring the pattern in modules/perc-distribution-tree/pom.xml. Spotless comment-wrap delta in MainDTSPreInstall.java is incidental.
natechadwick
approved these changes
Aug 24, 2026
natechadwick
deleted the
bugfix/65-bundle-zipslipguard-into-dts-preinstall
branch
August 24, 2026 21:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #65
MainDTSPreInstallreferencescom.percussion.security.io.ZipSlipGuard, butdelivery-tier-distribution/pom.xmldeclared no dependency onperc-security-utilsand its jar contained only this module's classes. Runningjava -jar delivery-tier-distribution.jarat pre-install time therefore threw:Changes
deliverytiersuite/delivery-tier-suite/delivery-tier-distribution/pom.xmlcom.percussion:perc-security-utils.maven-assembly-pluginwith thejar-with-dependenciesdescriptor so the produceddelivery-tier-distribution.jarbundles runtime deps (includingZipSlipGuard). Mirrors the pattern inmodules/perc-distribution-tree/pom.xml:452-475.deliverytiersuite/delivery-tier-suite/delivery-tier-distribution/src/main/java/com/percussion/preinstall/MainDTSPreInstall.javamvn-env.shduring rebuild).Validation
mvn-env.bat clean package -DskipTests -pl deliverytiersuite/delivery-tier-suite/delivery-tier-distributionsucceeds.jar tf target/delivery-tier-distribution.jar | grep ZipSlipGuard->com/percussion/security/io/ZipSlipGuard.classMain-Class: com.percussion.preinstall.MainDTSPreInstallJDK 1.8.0 compatible. No CHANGELOG.md entry per AGENTS.md.
Version.propertiesbuildNumbernot modified.