Skip to content

fix(dts): bundle ZipSlipGuard into delivery-tier-distribution jar (#65) #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
natechadwick merged 1 commit into from
Aug 24, 2026
+33 −2
Merged

fix(dts): bundle ZipSlipGuard into delivery-tier-distribution jar (#65) #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions deliverytiersuite/delivery-tier-suite/delivery-tier-distribution/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@
<tomcat-directory>${basedir}/target/tomcat</tomcat-directory>
</properties>
<dependencies>
<dependency>
<groupId>com.percussion</groupId>
<artifactId>perc-security-utils</artifactId>
<version>${project.parent.version}</version>
</dependency>
<dependency>
<groupId>com.percussion.deliverytier</groupId>
<artifactId>perc-metadata-services</artifactId>
Expand Down Expand Up @@ -909,6 +914,30 @@
</archive>
</configuration>
</plugin>
<plugin>
<artifactId>maven-assembly-plugin</artifactId>
<executions>
<execution>
<id>create-my-bundle</id>
<goals>
<goal>single</goal>
</goals>
<phase>package</phase>
<configuration>
<descriptorRefs>
<descriptorRef>jar-with-dependencies</descriptorRef>
</descriptorRefs>
<finalName>delivery-tier-distribution</finalName>
<appendAssemblyId>false</appendAssemblyId>
<archive>
<manifest>
<mainClass>com.percussion.preinstall.MainDTSPreInstall</mainClass>
</manifest>
</archive>
</configuration>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-antrun-plugin</artifactId>
Expand Down
6 changes: 4 additions & 2 deletions ...delivery-tier-distribution/src/main/java/com/percussion/preinstall/MainDTSPreInstall.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,12 +219,14 @@ public static void extractArchive(Path archiveFile, Path destPath, String folder
}

if (entry.isDirectory()) {
// codeql[java/zipslip] justification: ZipSlipGuard + canonical startsWith; re-review by 2027-07-31
// codeql[java/zipslip] justification: ZipSlipGuard + canonical startsWith; re-review by
// 2027-07-31
Files.createDirectory(newFile.toPath());
continue;
}
System.out.println("Creating file " + newFile);
// codeql[java/zipslip] justification: ZipSlipGuard + canonical startsWith; re-review by 2027-07-31
// codeql[java/zipslip] justification: ZipSlipGuard + canonical startsWith; re-review by
// 2027-07-31
Files.copy(archive.getInputStream(entry), newFile.toPath());

// Preserve executable permissions for shell scripts
Expand Down
Loading