Repository navigation
feat(textarea): reflect disabled and readonly props - #30910
Merged
Merged
Conversation
|
@KillerCodeMonkey is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
gnbm
requested review from
brandyscarney
and removed request for
OS-jacobbell
January 27, 2026 21:12
gnbm
added
type: feature request
brandyscarney
requested review from
thetaPC
and removed request for
brandyscarney
February 2, 2026 16:50
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
package: angular
thetaPC
reviewed
Feb 5, 2026
| await expect(page.locator('ion-range').first()).toHaveJSProperty('value', 50); | ||
| }); | ||
| test.describe('basic functionality', () => { | ||
| test('should have default values', async ({ page }) => { |
Contributor
There was a problem hiding this comment.
It seems like a lot of changes but I only moved the tests under a describe.
thetaPC
reviewed
Feb 5, 2026
| await expect(page.locator('#input-otp-note')).toHaveText('123'); | ||
| }); | ||
|
|
||
| test('should reflect props when component has a default value', async ({ page }) => { |
Contributor
There was a problem hiding this comment.
This is the new test added.
thetaPC
reviewed
Feb 5, 2026
| cy.get('ion-select').should('have.prop', 'value').and('eq', 'apples'); | ||
| }); | ||
| describe('basic functionality', () => { | ||
| it('should have default value', () => { |
Contributor
There was a problem hiding this comment.
It seems like a lot of changes but I only moved the tests under a describe.
thetaPC
reviewed
Feb 5, 2026
| cy.get('ion-select').should('have.prop', 'value').and('eq', 'apples'); | ||
| }); | ||
|
|
||
| it('should reflect props when component has a default value', () => { |
thetaPC
reviewed
Feb 5, 2026
| }); | ||
|
|
||
| describe('basic functionality', () => { | ||
| it('should have default value', () => { |
Contributor
There was a problem hiding this comment.
It seems like a lot of changes but I only moved the tests under a describe.
thetaPC
reviewed
Feb 5, 2026
| cy.get('ion-select').should('have.prop', 'value').and('eq', 'apples'); | ||
| }); | ||
|
|
||
| it('should reflect props when component has a default value', () => { |
ShaneK
approved these changes
Feb 10, 2026
ShaneK
left a comment
ShaneK
left a comment
Member
There was a problem hiding this comment.
Looks good to me, left a few quickly fixable nits that are just minor cleanup I'm kind of surprised linting didn't catch
thetaPC
changed the title
thetaPC
force-pushed
the
patch-3
branch
2 times, most recently
from
February 10, 2026 22:04
a660675 to
4d9cd7a
Compare
Contributor
|
Thank you for the PR! It'll be released in v8.8! |
3 tasks done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reflect
readonlyanddisabledproperties ation-textareahost element.Issue number: resolves #30911
What is the current behavior?
When setting readonly or disabled those settings are only reflected deep inside the ion-textarea component at the native textarea element.
Since there is no predefined readonly class it is hard to select readonly/disabled ion-textareas.
What is the new behavior?
Readonly and disabled props are reflected at ion-textarea host element.
Like they are for ion-inputs.
So it is consistent and will be helpful for easy element selection of disabled/readonly textareas (css, querySelector).
Does this introduce a breaking change?
Other information