Repository navigation
Conversation
Merge main at 46d6cc3 while preserving the teapot proxy behavior and current runtime/configuration ownership. Focused checks, native startup, clean docs, and full hooks pass. Full grasp/pour physical acceptance remains pending.
Keep this branch current with upstream main at e4df255. Preserve the PR behavior.
Integrate upstream main e907f82 to keep this branch current while preserving its feature scope.
Integrate upstream main d78054a to retain compatibility with current backend ownership and dependencies.
Integrate upstream main at ce2900d to keep the branch current with shared API and dependency changes. Validate the merged revision with focused checks and full formatting and lint hooks before committing. Remote CI remains separate.
Integrate upstream main at 6d37745 to keep the branch current with shared API and dependency changes. Validate the merged revision with focused checks and all repository formatting and lint hooks. Remote CI remains separate.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Rizon--Sharpa teapot example duplicated maintained robot settings, repaired generated contacts at every launch, and replaced Newton's proxy loop with a custom one-way collider copy. This cleanup simplifies the setup and uses Newton's standard two-way proxy coupling so MPM reaction forces reach the grasped pot.
CouplerProxyCfgdirectly and removed the custom stepping kernel, cached body indices, kinematic override, settings-only config subclass, and redundant default values.NewtonCfg, reused IsaacLab mesh triangulation, and removed duplicate robot-bundle preparation.The two example files have 150 fewer lines, including 119 fewer in
rizon_sharpa_teapot.py. The calibrated motion and gains are preserved. The small solver geometry adapter remains necessary: MJWarp needs convex grasp colliders while MPM needs the exact hollow shell; Newton otherwise exposes every shape attached to a proxy body. Bundle verification and robot asset repairs also remain.This draft targets current
develop. Coordinate with #8671, whose startup helper extraction touches the same example.Type of change
Release backport
developValidation
c452b98afthrough 18 simulated seconds / 14,400 steps on the L40. Startup IK splines, selected joints, limits, and initial targets were byte-identical to the pre-cleanup controller on the same native model. All 1,600 feedback comparisons matched exactly, including CPU arm/thumb state and GPU target buffers.uv run isaaclab --formatand changelog checks passed. Both affected pre-launch USD-import and concurrent-viewer contracts passed in the standalone environment.Before the setup cleanup, a matched headless coupling A/B on an otherwise idle NVIDIA L40 used 135,314 particles at 800 Hz, 4,800 steps per variant with the first 400 excluded, and CUDA graphs:
This single matched trial measured approximately 4.5% coupling overhead, excluding startup and rendering. It is not a repeated performance study of the cleaned-up setup.
Runtime: Python 3.12.14, Newton revision
71eeba16a717d4dcf0b9dd7056a7b6f863054dc3, Warp 1.17.0, MuJoCo/MuJoCo Warp 3.15.0, driver 595.58.03. Existing dependencies were reused without uv synchronization. No test files changed. Rendered documentation is unaffected; source instructions, CLI description, and changelog describe the behavior.Checklist
uv run isaaclab --formatCONTRIBUTORS.md