Repository navigation
test(ui): cover agent creation form validation - #3017
Open
chipfighter wants to merge 3 commits into
Open
chipfighter wants to merge 3 commits into
chipfighter wants to merge 3 commits into
Conversation
Signed-off-by: chipfighter <92256151+chipfighter@users.noreply.github.com>
Charlesthebird
previously approved these changes
Oct 1, 2026
Charlesthebird
enabled auto-merge
October 1, 2026 16:25
Signed-off-by: chipfighter <92256151+chipfighter@users.noreply.github.com>
github-actions
Bot
added
testing
Author
|
I synchronized this branch with The approval and auto-merge setting are still present. The latest CI Build run is awaiting approval to run. Could you approve it and add the PR to the merge queue after the required checks pass? |
Charlesthebird
disabled auto-merge
October 12, 2026 19:44
Collaborator
|
This has some merge conflicts |
moezdil
reviewed
Oct 15, 2026
| await expect(submit).toBeDisabled(); | ||
| await expect(problems).toHaveText("Choose a harness."); | ||
| if (harness === "inline") { | ||
| await chooseSource(page, "harness", "inline"); |
Contributor
There was a problem hiding this comment.
inline harness is gone on main, does this run?
Signed-off-by: chipfighter <92256151+chipfighter@users.noreply.github.com>
github-actions
Bot
added
testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cover creation-form validation in the existing Agent CRUD journeys for referenced and inline templates, both using a referenced harness:
Reuse the shared required-field helper and preserve the current two CRUD cases and chat-entry coverage. The change is limited to
ui/playwright/tests/agents/agent-crud.spec.ts(+20/-2) againstmainat73e540a.Validation
yarn install --immutable— passed.yarn typecheck— passed.yarn lint— 0 errors; 6 existing warnings in unrelated files.yarn test:pw playwright/tests/agents/agent-crud.spec.ts --project=chromium --project=firefox --workers=2— all 4 tests passed on Windows.git diff --check— passed.