Skip to content

test(ui): cover agent creation form validation #3017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chipfighter wants to merge 3 commits into
base: main
Choose a base branch
from
Open

test(ui): cover agent creation form validation #3017

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
490f4e3
test(ui): cover agent creation form validation
chipfighter Sep 30, 2026
241979a
chore: merge upstream main into agent form validation
chipfighter Oct 10, 2026
033fada
test(ui): adapt agent form validation to referenced harnesses
chipfighter Oct 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions ui/playwright/tests/agents/agent-crud.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import type { Page } from "@playwright/test";
import { test, expect } from "../../fixtures/test";
import { agentNewChat, dataRows, expectSettled, loadPage, rowNamed, routes } from "../../helpers/app";
import { confirmDelete, selectOption } from "../../helpers/resource";
import { confirmDelete, expectRequired, selectOption } from "../../helpers/resource";
import { clickNav } from "../../helpers/nav";

type Source = "reference" | "inline";
Expand All @@ -22,18 +22,36 @@ for (const template of CASES) {
await page.getByTestId("agents-new").click();
await expect(page).toHaveURL(/\/agents\/new$/);
await expect(page.getByTestId("agent-form-namespace")).toContainText("kagent");
const submit = page.getByTestId("agent-form-submit");
const problems = page.getByTestId("agent-form-problems");

await expect(submit).toBeDisabled();
await expect(problems).toHaveText("A name is required.");
await expectRequired(page, {
marked: ["Name", "Namespace", "Shared template", "Shared harness"],
unmarked: [],
});
await page.getByTestId("agent-form-name").fill(name);
await expect(submit).toBeDisabled();
await expect(problems).toHaveText("Choose a template.");

if (template === "inline") {
await chooseTemplateSource(page, "inline");
await expect(submit).toBeDisabled();
await expect(problems).toHaveText("Choose a model configuration for the inline template.");
await selectOption(page, "template-form-model", "default-model-config");
await page.getByTestId("template-form-description").fill("Inline before edit");
await page.getByTestId("template-form-prompt").fill("You answer briefly.");
} else {
await selectOption(page, "agent-form-template-ref", "shared-brain");
}
await expect(submit).toBeDisabled();
await expect(problems).toHaveText("Choose a harness.");
await selectOption(page, "agent-form-harness-ref", "k8s-agent");
await page.getByTestId("agent-form-submit").click();
await expect(problems).toHaveCount(0);
await expect(submit).toBeEnabled();
await expect(page).toHaveURL(/\/agents\/new$/);
await submit.click();
});

await test.step("2. it appears in the list with its sources and status", async () => {
Expand Down
Loading