chore: replace deprecated Resources.getColor and Gradle space-assignment DSL#46
Draft
devin-ai-integration[bot] wants to merge 1 commit into
Draft
chore: replace deprecated Resources.getColor and Gradle space-assignment DSL#46devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…ent DSL Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
No SDK bump needed —
launchdarkly-android-client-sdkis already pinned to5.13.2, the latest 5.x on Maven Central. This PR only clears deprecation warnings that the build currently emits.Two deprecations fixed:
Resources.getColor(int)(deprecated since API 23) →ContextCompat.getColor(this, id)inMainActivity(5 call sites, both the initial render and the flag-change listener).app/build.gradle, which Gradle 9 warns "will fail with an error in Gradle 10":applicationId,versionCode,versionName,minifyEnabled,source/targetCompatibility)One remaining Gradle 9 deprecation ("Using a Project object as a dependency notation") originates inside the Android Gradle Plugin, not this repo's scripts, so it is not actionable here.
How verified
./gradlew clean assembleDebug— BUILD SUCCESSFUL, and both the KotlingetColorwarnings and thenamespacespace-assignment warning are gone (verified with--warning-mode all).ContextCompat.getColorstyling path works at runtime:Link to Devin session: https://app.devin.ai/sessions/7a61003c1e984050ad12233068fab8a3