Skip to content

chore: replace deprecated Resources.getColor and Gradle space-assignment DSL #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
devin-ai-integration wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −13
Draft

chore: replace deprecated Resources.getColor and Gradle space-assignment DSL #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,24 +3,24 @@ plugins {
}

android {
namespace "com.launchdarkly.hello_android"
compileSdk 37
namespace = "com.launchdarkly.hello_android"
compileSdk = 37
defaultConfig {
applicationId "com.launchdarkly.hello_android"
applicationId = "com.launchdarkly.hello_android"
minSdkVersion(24)
targetSdkVersion(34)
versionCode 1
versionName "1.0"
versionCode = 1
versionName = "1.0"
}
buildTypes {
release {
minifyEnabled false
minifyEnabled = false
proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro'
}
}
compileOptions {
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8
sourceCompatibility = JavaVersion.VERSION_1_8
targetCompatibility = JavaVersion.VERSION_1_8
}
}

Expand Down
11 changes: 6 additions & 5 deletions app/src/main/java/com/launchdarkly/hello_android/MainActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import android.view.View
import android.widget.TextView
import androidx.appcompat.app.AlertDialog
import androidx.appcompat.app.AppCompatActivity
import androidx.core.content.ContextCompat
import com.launchdarkly.hello_android.MainApplication.Companion.LAUNCHDARKLY_MOBILE_KEY
import com.launchdarkly.sdk.android.LDClient

Expand Down Expand Up @@ -36,11 +37,11 @@ class MainActivity : AppCompatActivity() {
)

// Style the display
textView.setTextColor(resources.getColor(R.color.colorText))
textView.setTextColor(ContextCompat.getColor(this, R.color.colorText))
if(flagValue) {
fullView.setBackgroundColor(resources.getColor(R.color.colorBackgroundTrue))
fullView.setBackgroundColor(ContextCompat.getColor(this, R.color.colorBackgroundTrue))
} else {
fullView.setBackgroundColor(resources.getColor(R.color.colorBackgroundFalse))
fullView.setBackgroundColor(ContextCompat.getColor(this, R.color.colorBackgroundFalse))
}

// to register a listener to get updates in real time
Expand All @@ -52,9 +53,9 @@ class MainActivity : AppCompatActivity() {
changedFlagValue.toString()
)
if(changedFlagValue) {
fullView.setBackgroundColor(resources.getColor(R.color.colorBackgroundTrue))
fullView.setBackgroundColor(ContextCompat.getColor(this, R.color.colorBackgroundTrue))
} else {
fullView.setBackgroundColor(resources.getColor(R.color.colorBackgroundFalse))
fullView.setBackgroundColor(ContextCompat.getColor(this, R.color.colorBackgroundFalse))
}
}
}
Expand Down
Loading