Repository navigation
Set iPhone app display name to Journal - #105
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
RCmerci
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set the installed app’s Home screen display name to
Journal(capital J) through the canonicalapple/Info.plist. The maintained Apple builder and Fastlane project generator inherit this key.Only
CFBundleDisplayNamechanges. Bundle IDcom.logseq.journal, internalCFBundleName, executable/product references, thelogseqjournalcallback scheme, App Store Connect identity/name and testing audiences remain unchanged.Validation:
git diff --checkpassed; every other plist field matches main.68aa6dffa8a348d6e3269dcbab35cd7834c187f9, the actual source-based device build, Fastlane prepare, Release archive, signed export and strict verify lane passed. Generated plist, archive and final IPA all containJournal; the final IPA has noInfoPlist.stringsoverride. Checks passed for exact source SHA, iPhone-only family, arm64/iPhoneOS, signature/profile/entitlements and executable/dSYM UUID agreement. New-head independent source and final IPA review found no issues. Exact-head CI is pending.cross_abi_validated=falseand native Debug/Swift Release provenance. An archive or signing check does not establish full cross ABI or physical-device runtime acceptance.