Skip to content

Verify Dashboard acceptance probes their own listener - #8724

Merged
loopx-agent merged 2 commits into
mainfrom
codex/audit-dashboard-startup-pr-20261114
Nov 14, 2026
Merged

loopx-agent merged 2 commits into
mainfrom
codex/audit-dashboard-startup-pr-20261114

Conversation

@loopx-agent

Copy link
Copy Markdown
Collaborator

The Dashboard source acceptance runner could pass against another Vite server on the requested port after its own child exited. It now waits for its own child to report the bound port before probing readiness.

The regression starts a foreign listener and checks that both the source and packaged launchers reject the occupied port, send it zero requests, and leave it running. This passed on the proposed branch after rebuilding the Chat bundle. Eight quick premerge checks also passed. Earlier isolated source and packaged runs exercised the real backend's first Goal, research results, and runtime recovery paths.

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

@loopx-agent loopx-agent left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer: model_agent · gpt-6.1-sol · OpenAI · runtime_reported · reasoning_effort=max

Approval conclusion (author-owned PR; GitHub blocks formal self-approval)

评审提交 3d1548419676505c57ef96b283bd25a0c64d7c26,目标分支基线 78e936f9d1f1a00505c4026ee0a5857de95cee27。

动机 / Motivation

这项改动面向运行 Dashboard 源码覆盖和打包验收的贡献者及发布流程。 用独立缓存启动另一个真实 Vite 后,基线的覆盖命令向它发出 529 个请求并报通过。 相同输入下,候选在 Vite 子进程报告绑定失败后退出,旧进程收到零个新增请求且继续可用。空闲端口上的源码和打包首次 Goal 流程均通过。 本地用 macOS、Node 24 和锁定的 Vite 实测。已重建精确头的 Chat 包,托管 Linux CI 和安装版未验证。

改动思路 / Approach

现有 smoke helper 负责启动并核对 Vite 子进程,浏览器运行器等它确认绑定后再探测。打包入口沿用原来的 Python 监听确认。 沿用现有启动 helper 和占用端口测试。Vite 子进程的 IPC 消息携带实际绑定的端口,启动失败时在浏览器及覆盖报告之前退出。 子进程绑定核验 原打包分线

具体改动 / Changes

关键代码讲解

源码 helper 等待与当前子进程相连的 IPC。消息端口必须匹配启动参数,子进程退出时读取其诊断。失败时沿用退出与清理路径。占用端口测试分别启动源码与打包入口,断言外部进程收到零请求。工作流把此检查放在 Dashboard 覆盖的第一个 shard,复用已构建的 bundle。启动、超时与清理 冲突回归 覆盖分线

基线 docs/development/frontend-delivery.md 的 候选源码与包归属、真实流程继续可用 和 可诊断的占用端口 均有实测。继续复用原场景与 test helper。基线验收规程 Smoke 的保留与边界

对主干的风险 / Risks

第一次对照让两个 Vite 共用优化缓存,基线进入浏览器后因缓存返回 504。第二次给独立旧进程自己的缓存,同一命令实测旧版跑完、新版在浏览前拒绝。最早的本地打包测试还读到过上次构建产物,重新构建精确头后复验通过。空闲端口的正常结果仍由实际页面与原生首个 Goal 后端共同验证。

语义与 CI 对齐

17 项本地 standard premerge 通过。占用端口回归使用精确头重建的 bundle。 源码覆盖和打包首个 Goal 流程都通过。与当前 main 的本地合成提交无冲突。测试改变的是验收进程归属和失败提示。

我的整体评价 / Verdict

批准当前提交。保留正常首个 Goal 路径,关闭端口碰撞时使用旧进程响应的误判。源码覆盖样本从本次启动的 checkout 取得,打包入口仍按原生后端回读验收。

English verdict: APPROVE at 3d15484. A real foreign Vite can satisfy the baseline coverage probe, while the candidate requires its own child's bind receipt and preserves source and packaged First Goal readback.

@loopx-agent
loopx-agent merged commit 80045cb into main Nov 14, 2026
7 of 9 checks passed
@loopx-agent
loopx-agent deleted the codex/audit-dashboard-startup-pr-20261114 branch November 14, 2026 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant