Skip to content

fix: correct query result memory estimate #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrispader merged 5 commits into from
Jul 23, 2026
Merged

fix: correct query result memory estimate #287

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a0c803d
fix: correct query result memory estimate
chrispader Jul 14, 2026
fb4c484
fix: improve SQLite result memory handling
chrispader Jul 14, 2026
d73e9de
test: cover query result external memory
chrispader Jul 17, 2026
6fbc0ba
Revert "test: cover query result external memory"
chrispader Jul 23, 2026
f1f3a69
Revert "fix: improve SQLite result memory handling"
chrispader Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-native-nitro-sqlite/cpp/hybridObjects/HybridNitroSQLiteQueryResult.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ namespace {
size_t getRowExternalMemorySize(const SQLiteQueryResultRow& row) {
size_t bucketMemory = row.bucket_count() * sizeof(void*);
constexpr size_t nodePadding = 24;
size_t nodesMemory = row.size() * (sizeof(std::pair<std::string, SQLiteValue>) * nodePadding);
size_t nodesMemory = row.size() * (sizeof(std::pair<std::string, SQLiteValue>) + nodePadding);
return bucketMemory + nodesMemory;
}

Expand Down
Loading