Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause
MatrixOne Coverage wraps the whole Go test phase with a 3600-second deadline, but does not set
go test -timeout. Go therefore still applies its default 10-minute deadline to each package. In the failedmatrixorigin/matrixone#29368run,pkg/tests/issues/isolatedhad completed 11 tests in 574.35 seconds before its final test began, then hit the package alarm at 600 seconds. The final test's name in the panic is incidental to the aggregate package runtime.Change
Set a finite 20-minute Go package deadline below the existing 60-minute whole-suite deadline. In the observed run this package began about 11 minutes into the phase, so a full 20-minute package run would still leave about 29 minutes for remaining work. This corrects the nested budget mismatch while retaining Go's per-package stack dump for real stalls.
Related: matrixorigin/matrixone#29368. The separate CN shutdown-context observation and slow fixture optimization remain tracked there; this PR does not claim to fix those paths.
Validation
TestAutoIDCacheRestartAndDisabledNode, 157.35 seconds inTestIssue28234ExceptAllCluster, and 115.39 seconds in the other nine passed tests before the package alarm.git diff --checkpassed.Full reusable-workflow validation requires a MatrixOne PR run after this CI PR is merged. Revert this three-line change to restore the prior package deadline if needed.