Skip to content

[MCC-1514181] Error "Unsupported field type and format" for some Stri…#47

Merged
butsyk-mdsol merged 1 commit into
mainfrom
feat/MCC-1514181
Jun 12, 2026
Merged

[MCC-1514181] Error "Unsupported field type and format" for some Stri…#47
butsyk-mdsol merged 1 commit into
mainfrom
feat/MCC-1514181

Conversation

@butsyk-mdsol

@butsyk-mdsol butsyk-mdsol commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

…ng columns

feature/bug/enhance/refactor/tech_debt/hotfix

  • Error "Unsupported field type and format" for some String columns.
  • MCC-1514181

Checklist

  • Review the pull request to fix typos and ensure variable/function names are intuitive, etc.
  • Make sure the pull request does not have excessive number of unnecessary commits. Utilize the git commit --amend --no-edit command to reduce commit messages when making small file changes (like changing linespacing).
  • Make sure you have added unit tests for the code changes. Tests should be added in the tests/ folder.
  • Modify docs, if required. Add any new documentation in the doc/ folder.
  • Rebase on latest active development branch (develop/main).

Changes Summary

[Python Lib] Error "Unsupported field type and format" for some String columns. Fix type mapping.

Deployment Notes

In addition to IAC/code, add any notes for reviewer should know.

Copilot AI review requested due to automatic review settings June 12, 2026 12:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the Arrow→pandas conversion in the service mapper to address failures when fetching datasets that include certain string-typed columns, by changing the dtype mapping behavior during DataTablepd.DataFrame conversion.

Changes:

  • Update resource_to_fetched_data to call to_pandas(types_mapper=pd.ArrowDtype) when decoding Arrow IPC streams.
  • Remove several get_datasets input-validation unit tests from the paginated datasets test suite.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
dataconnect/service/mappers.py Changes Arrow-to-pandas conversion to use pandas Arrow-backed dtypes via types_mapper.
tests/test_get_datasets_paginated.py Deletes multiple runtime input-validation tests for get_datasets pagination/UUID parameters.
Comments suppressed due to low confidence (1)

tests/test_get_datasets_paginated.py:150

  • This test file removes all input-validation test cases for get_datasets (invalid UUID, nil UUID, invalid/non-int page and page_size) without adding replacement coverage. This change is unrelated to the PR’s stated goal (string type mapping) and reduces protection against accidental regressions in the public API’s runtime validation behavior.
    def test_translates_transport_errors(self) -> None:
        transport = _FakeTransport(error=TransportError(error_code="CONN", message="cannot connect"))
        service = DefaultDataConnectService(transport)

        with pytest.raises(Exception, match="cannot connect"):

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread dataconnect/service/mappers.py
@butsyk-mdsol butsyk-mdsol merged commit 2bca2c6 into main Jun 12, 2026
4 checks passed
@butsyk-mdsol butsyk-mdsol deleted the feat/MCC-1514181 branch June 12, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants