Skip to content

[MCC-1514181] Error "Unsupported field type and format" for some Stri… #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
butsyk-mdsol merged 1 commit into from
Jun 12, 2026
Merged

[MCC-1514181] Error "Unsupported field type and format" for some Stri… #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dataconnect/service/mappers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def resource_to_fetched_data(table: DataTable) -> pd.DataFrame:

ipc_buffer = pa.BufferReader(table.ipc_bytes)
with pa.ipc.open_stream(ipc_buffer) as reader:
return reader.read_all().to_pandas()
return reader.read_all().to_pandas(types_mapper=pd.ArrowDtype)
Comment thread
butsyk-mdsol marked this conversation as resolved.


def resource_to_dataset(resource: ResourceInfo) -> Dataset:
Expand Down
45 changes: 0 additions & 45 deletions tests/test_get_datasets_paginated.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@

import pytest

from dataconnect.exceptions import ValidationError
from dataconnect.models import Dataset, PaginatedResponse, Pagination
from dataconnect.service.default import DefaultDataConnectService
from dataconnect.transport.errors import TransportError
Expand Down Expand Up @@ -144,50 +143,6 @@ def test_builds_correct_request_body(self) -> None:
"page_size": 10,
}

def test_raises_validation_error_for_invalid_uuid(self) -> None:
transport = _FakeTransport(resources=[])
service = DefaultDataConnectService(transport)

with pytest.raises(ValidationError, match="study_environment_uuid must be a valid UUID"):
service.get_datasets(study_environment_uuid="not-a-uuid") # type: ignore[arg-type]

def test_raises_validation_error_for_zero_uuid(self) -> None:
transport = _FakeTransport(resources=[])
service = DefaultDataConnectService(transport)

with pytest.raises(ValidationError, match="study_environment_uuid must not be empty"):
service.get_datasets(study_environment_uuid=UUID(int=0))

@pytest.mark.parametrize("page", [0, -1, -100])
def test_raises_validation_error_for_invalid_page(self, page: int) -> None:
transport = _FakeTransport(resources=[])
service = DefaultDataConnectService(transport)

with pytest.raises(ValidationError, match="page must be a positive integer"):
service.get_datasets(study_environment_uuid=_STUDY_ENV_UUID, page=page)

def test_raises_validation_error_for_non_int_page(self) -> None:
transport = _FakeTransport(resources=[])
service = DefaultDataConnectService(transport)

with pytest.raises(ValidationError, match="page must be a positive integer"):
service.get_datasets(study_environment_uuid=_STUDY_ENV_UUID, page="2") # type: ignore[arg-type]

@pytest.mark.parametrize("page_size", [0, -1, -50])
def test_raises_validation_error_for_invalid_page_size(self, page_size: int) -> None:
transport = _FakeTransport(resources=[])
service = DefaultDataConnectService(transport)

with pytest.raises(ValidationError, match="page_size must be a positive integer"):
service.get_datasets(study_environment_uuid=_STUDY_ENV_UUID, page_size=page_size)

def test_raises_validation_error_for_non_int_page_size(self) -> None:
transport = _FakeTransport(resources=[])
service = DefaultDataConnectService(transport)

with pytest.raises(ValidationError, match="page_size must be a positive integer"):
service.get_datasets(study_environment_uuid=_STUDY_ENV_UUID, page_size="25") # type: ignore[arg-type]

def test_translates_transport_errors(self) -> None:
transport = _FakeTransport(error=TransportError(error_code="CONN", message="cannot connect"))
service = DefaultDataConnectService(transport)
Expand Down
Loading