Skip to content

feat(runner-policy): register the ci-workflows v0.64.2 pr-review-cli contract - #853

Merged
kyle-sexton merged 1 commit into
mainfrom
feat/runner-policy-pr-review-cli-v0.64.2
Oct 23, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
feat/runner-policy-pr-review-cli-v0.64.2

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

No related issue: registers the pr-review-cli contract at ci-workflows v0.64.2 so claude-code-plugins' review callers can repin to it.

Summary

Registers pr-review-cli.yml@6d6cb798e7cb7560a0f9327d8a22398961c23b31 (ci-workflows v0.64.2).

Fix

v0.64.2 changes only how pr-review-cli's steps read the GitHub API (ci-workflows#869): the PR file list is read once instead of three times, and pulls.get twice instead of three times. Inputs, secrets and routing are unchanged, so the contract copies the v0.64.1 entry forward verbatim.

Verification

  • node --test runner-policy.test.mjs in components/runner-policy: 340 pass, including the new copy-forward test.

Related

  • Same shape as #851 (v0.64.1).

🤖 Generated with Claude Code

…contract

v0.64.2 changes only how pr-review-cli's steps read the GitHub API
(ci-workflows#869), so its contract copies the v0.64.1 entry forward
verbatim.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-23T15:28:48.888605Z c633798 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

claude-review reviewed c633798ca6f019e861211a1b961a54a51e827ecf: 0 finding(s), 0 as inline comments.

No findings.

Scope. The PR adds one approvedReusableWorkflowContracts entry to components/runner-policy/policy.json: pr-review-cli.yml@6d6cb798…. It also adds a copy-forward test in runner-policy.test.mjs.

What I checked.

  • I read the new entry (lines 836–856) next to the v0.64.1 entry (lines 815–835). Routing, fixedRunsOn, all 11 allowedInputs and both allowedSecrets entries are identical, so the "copies forward verbatim" claim holds for the file as committed.
  • The new test uses deepEqual against the v0.64.1 entry and asserts exactly one key ends in the new SHA. It would fail if the entry drifted or were duplicated.
  • The new entry sits after the v0.64.1 one and matches the layout of earlier entries.
  • No hold class applies: there is no model or spend change, no trust-gate path, and no security finding.
  • No closing issue exists (the PR states "No related issue" with a reason), so there are no acceptance criteria to check. The PR body follows the contract.

Unverified.

  • I did not confirm that ci-workflows v0.64.2 (6d6cb798…) really leaves the workflow's inputs, secrets and runner routing unchanged. That claim comes from the PR body, and I did not fetch the upstream ref.
  • I did not run the test suite. The "340 pass" figure is the author's claim.

@github-actions

Copy link
Copy Markdown

claude-security-review reviewed c633798ca6f019e861211a1b961a54a51e827ecf: 0 finding(s), 0 as inline comments.

Security review: PR #853 at c633798

No security findings.

critical-findings: 0

Changes reviewed

  • components/runner-policy/policy.json adds an approved reusable-workflow contract for pr-review-cli.yml pinned at 6d6cb798… (v0.64.2).
  • components/runner-policy/runner-policy.test.mjs adds a test that this entry deep-equals the v0.64.1 entry and that it appears exactly once.

What I checked

  • The new entry matches the v0.64.1 entry (9aca743c…) at policy.json lines 815–835 and 836–856. The routing is hosted-only on ubuntu-24.04, the allowedInputs list is identical, and the two secrets map to the same REVIEWS_* repository secrets. It adds no input, no secret, no runner option and no wider routing.
  • The new entry pins a full 40-character commit SHA, not a tag or branch, so the approval can't drift.
  • The test pins the SHA and asserts parity with the prior entry, so a later divergence would fail CI.

Not verified

  • I couldn't confirm that 6d6cb798… is the v0.64.2 tag, or that it changes only how pr-review-cli.yml reads the GitHub API, as the test comment claims. The gh api compare against ci-workflows was not run because it needed approval. The PR's CI and reviewers should confirm the SHA against the tag.
  • The PR touches none of the trust-gate paths: trusted-actors, check-trusted-trigger, CODEOWNERS and .gitmodules. It touches no plugin manifest and no standing instruction, so neither the manifest lines nor the instruction-surface lens applies. No hold.

@kyle-sexton
kyle-sexton merged commit 80e162c into main Oct 23, 2026
22 checks passed
@kyle-sexton
kyle-sexton deleted the feat/runner-policy-pr-review-cli-v0.64.2 branch October 23, 2026 15:33
kyle-sexton added a commit that referenced this pull request Oct 23, 2026
…and pr-review-cli contracts (#856)

No related issue: G6 part 2 of the lane-funding plan (owner-approved
2026-10-23).

## Summary

Registers `intake-triage.yml@d02b8697e092705153f0996549b05f95a446bb52`
and `pr-review-cli.yml@d02b8697e092705153f0996549b05f95a446bb52`
(ci-workflows
[v0.65.0](https://github.com/melodic-software/ci-workflows/releases/tag/v0.65.0)),
so claude-code-plugins' intake and review callers can re-pin to the
release whose lane-outcome record carries `costUsd`.

## Fix

v0.65.0 changes only report-lane-outcome's `classify.cjs`
([ci-workflows#872](melodic-software/ci-workflows#872)).
Both reusables reach that action through `$/`. Neither workflow file
changed since its last registered SHA (`git log 2fe38c03..v0.65.0 --
.github/workflows/intake-triage.yml` and `git log v0.64.2..v0.65.0 --
.github/workflows/pr-review-cli.yml` list no commits), so both contracts
copy their prior entries forward verbatim.

## Verification

- `node --test runner-policy.test.mjs` in `components/runner-policy`:
341 pass. That count includes the new copy-forward test, which checks
both entries deep-equal their prior SHAs' entries and that exactly two
contracts name the new SHA.
- Left out: nothing.

## Related

- Same shape as
[#853](#853)
(v0.64.2).
- Next: the standards sync into claude-code-plugins, then that
repository's caller re-pin.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
kyle-sexton added a commit that referenced this pull request Oct 24, 2026
…contract (#864)

No related issue: follow-up to
[ci-workflows#874](melodic-software/ci-workflows#874),
which fixed a review-lane failure on
[claude-code-plugins#9545](melodic-software/claude-code-plugins#9545).

## Summary

Registers `pr-review-cli.yml@b49ac366bb3426039363a6927c41512e44533808`
(ci-workflows
[v0.65.1](https://github.com/melodic-software/ci-workflows/releases/tag/v0.65.1)),
so claude-code-plugins' two review callers can re-pin to the release
that passes the review between jobs as an artifact.

## Fix

v0.65.1 changes only `pr-review-cli.yml`'s jobs and its tests: the
review and the last marker's summary now travel as a checked artifact
instead of a job output, which the runner dropped whenever the text
contained a registered secret's value. The workflow's `on.workflow_call`
inputs, secrets and runner did not change (`git diff d02b8697..b49ac366
-- .github/workflows/pr-review-cli.yml` touches the header comment and
`jobs:` only), so the contract copies its v0.65.0 entry forward
verbatim.

## Verification

- `node --test runner-policy.test.mjs` in `components/runner-policy`:
343 pass, 0 fail. That includes the new copy-forward test, which checks
the new entry deep-equals the v0.65.0 entry and that exactly one
contract names the new SHA.
- `npx --no-install @biomejs/biome check` (2.5.15) on both changed
files: clean.

## Related

- Same shape as
[#856](#856) (v0.65.0)
and [#853](#853)
(v0.64.2).
- Next: the standards sync into claude-code-plugins, then that
repository's review-caller re-pin.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant