Skip to content

feat(runner-policy): register the ci-workflows v0.65.1 pr-review-cli contract - #864

Merged
kyle-sexton merged 1 commit into
mainfrom
feat/runner-policy-pr-review-cli-v0.65.1
Oct 24, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
feat/runner-policy-pr-review-cli-v0.65.1

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

No related issue: follow-up to ci-workflows#874, which fixed a review-lane failure on claude-code-plugins#9545.

Summary

Registers pr-review-cli.yml@b49ac366bb3426039363a6927c41512e44533808 (ci-workflows v0.65.1), so claude-code-plugins' two review callers can re-pin to the release that passes the review between jobs as an artifact.

Fix

v0.65.1 changes only pr-review-cli.yml's jobs and its tests: the review and the last marker's summary now travel as a checked artifact instead of a job output, which the runner dropped whenever the text contained a registered secret's value. The workflow's on.workflow_call inputs, secrets and runner did not change (git diff d02b8697..b49ac366 -- .github/workflows/pr-review-cli.yml touches the header comment and jobs: only), so the contract copies its v0.65.0 entry forward verbatim.

Verification

  • node --test runner-policy.test.mjs in components/runner-policy: 343 pass, 0 fail. That includes the new copy-forward test, which checks the new entry deep-equals the v0.65.0 entry and that exactly one contract names the new SHA.
  • npx --no-install @biomejs/biome check (2.5.15) on both changed files: clean.

Related

  • Same shape as #856 (v0.65.0) and #853 (v0.64.2).
  • Next: the standards sync into claude-code-plugins, then that repository's review-caller re-pin.

🤖 Generated with Claude Code

…contract

v0.65.1 passes the review between pr-review-cli's jobs as an artifact
(ci-workflows#874). Inputs, secrets and runner are unchanged, so the
contract copies its v0.65.0 entry forward.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-24T03:06:39.110889Z 743e237 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

claude-security-review reviewed 743e237e0e7d1b2a9c1772067b4e3f2f7f0a9b3c: 0 finding(s), 0 as inline comments.

Security review: PR #864 at 743e237

critical-findings: 0

No security issues found.

What the PR changes

  • It adds one approvedReusableWorkflowContracts entry to components/runner-policy/policy.json. The entry is for pr-review-cli.yml@b49ac366… (the v0.65.1 pin).
  • It adds a test in components/runner-policy/runner-policy.test.mjs. The test asserts the new entry deep-equals the v0.65.0 entry (@d02b8697…) and that exactly one entry exists for the new SHA.

What I checked

  • I compared the new entry with the @d02b8697… entry in the file. They are identical:
    • routing is hosted-only, and fixedRunsOn is ubuntu-24.04.
    • the 11 allowedInputs are the same.
    • allowedSecrets is the same: CLAUDE_API_KEY and CLAUDE_CODE_OAUTH_TOKEN, mapped to the same REVIEWS_* secrets.
  • The new entry grants no new input, secret, or runner, and it is pinned to a full 40-character SHA, not a tag or branch.
  • The older pins stay approved, so the PR widens nothing for them. It only allows the new revision to be called with the same grants.
  • The new test pins the copy-forward claim, so a later edit to the entry would fail it.

What I could not check

  • I could not confirm that b49ac366… is the commit the v0.65.1 tag points to. The gh api call against melodic-software/ci-workflows needed approval that this lane did not have, and I did not work around that.
  • I could not confirm the PR's claim that v0.65.1 changes only pr-review-cli.yml's internals (artifact instead of job output) and leaves its inputs, secrets and runner unchanged. That needs the upstream workflow file.
  • Both checks are a one-time maintainer step on the ci-workflows release. Neither is a defect in this diff.

Other lenses

  • This is not a trust-gate path, so no hold applies.
  • No instruction-surface deletions or plugin manifests are touched, so the register lookup did not apply.
  • No hold is returned.

@github-actions

Copy link
Copy Markdown

claude-review reviewed 743e237e0e7d1b2a9c1772067b4e3f2f7f0a9b3c: 0 finding(s), 0 as inline comments.

No findings.

The PR adds a pr-review-cli.yml@b49ac366… contract to components/runner-policy/policy.json. It also adds a copy-forward test in runner-policy.test.mjs.

What I checked myself:

  • Copy-forward claim: the new entry at policy.json lines 930–949 is identical to the v0.65.0 entry at d02b8697… (lines 909–928). Routing, fixedRunsOn, all 11 allowedInputs and both allowedSecrets match.
  • Test: the new test asserts deep equality with the v0.65.0 entry and that exactly one contract names the new SHA. It follows the same shape as the neighbouring tests at lines 9934 and 9954.

What I could not check:

  • Workflow contents: I did not fetch ci-workflows at either SHA. The claim that v0.65.1 changes only the header comment and jobs: of pr-review-cli.yml is the author's and is unverified here.
  • Test and lint results: I did not run the author's test and biome results (343 pass, biome clean), so they are author-claimed.

The PR body matches the contract in .claude/rules/pr-body-contract.md. It opens with No related issue: <reason>, has all four sections, and has no line starting with committer. There is no closing issue to check criteria against. There are no plugin manifests in the diff, and nothing holds the PR for a person: it adds no cost and touches no trust-gate files.

@kyle-sexton
kyle-sexton merged commit 48e1c79 into main Oct 24, 2026
22 checks passed
@kyle-sexton
kyle-sexton deleted the feat/runner-policy-pr-review-cli-v0.65.1 branch October 24, 2026 03:11
kyle-sexton added a commit that referenced this pull request Oct 24, 2026
…contract (#866)

No related issue: follow-up to
[ci-workflows#875](melodic-software/ci-workflows#875),
which
[claude-code-plugins](https://github.com/melodic-software/claude-code-plugins)'
two review callers will pin to.

## Summary

Registers `pr-review-cli.yml@e7f935fc799fc9c78f1dc52646e8bbd54823502a`,
which is ci-workflows
[v0.65.2](https://github.com/melodic-software/ci-workflows/releases/tag/v0.65.2).

## Fix

v0.65.2 changes only how `pr-review-cli.yml` works inside its jobs:

- Each job now writes the job token's `api-budget` notice.
- The hold step no longer adds the cost hold again once the owner has
recorded a cost decision for the pull request.

The `on.workflow_call` inputs, secrets and runner are the same. `git
diff b49ac366..e7f935fc -- .github/workflows/pr-review-cli.yml` changes
the header comment, the `allowed-author-ids` description and the jobs
only. That input's name and type are unchanged, and only its description
now also covers whose cost decision counts. The contract lists input
names, so it copies its v0.65.1 entry forward verbatim.

## Verification

- `node --test runner-policy.test.mjs` in `components/runner-policy`:
344 pass, 0 fail. This includes the new copy-forward test. It checks
that the new entry deep-equals the v0.65.1 entry and that exactly one
contract names the new SHA.
- `biome check` on both changed files: clean.

## Related

- Same shape as
[#864](#864)
(v0.65.1).

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
kyle-sexton added a commit that referenced this pull request Oct 24, 2026
…contract (#867)

No related issue: follow-up to
[ci-workflows#876](melodic-software/ci-workflows#876).
claude-code-plugins' review callers pin to this release in
[claude-code-plugins#9589](melodic-software/claude-code-plugins#9589).

## Summary

Registers `pr-review-cli.yml@f133c6651f866845e18595d26cf59d4043b5b642`,
which is ci-workflows
[v0.65.3](https://github.com/melodic-software/ci-workflows/releases/tag/v0.65.3).

## Fix

v0.65.3 changes only `apply-review-hold/hold.cjs` and its test. `git
diff --stat e7f935fc f133c665` lists those two files and nothing else.
`pr-review-cli.yml` is byte-identical to v0.65.2, so the contract copies
the v0.65.2 entry from
[#866](#866) forward
verbatim.

## Verification

- `node --test runner-policy.test.mjs` in `components/runner-policy`:
345 pass, 0 fail. This includes the new copy-forward test.

## Related

- [#866](#866)
(v0.65.2) and
[#864](#864) (v0.65.1)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant