Skip to content

feat(runner-policy): register the ci-workflows v0.65.6 pr-review-cli contract - #874

Merged
kyle-sexton merged 1 commit into
mainfrom
feat/runner-policy-v0.65.6
Oct 24, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
feat/runner-policy-v0.65.6

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

Refs: melodic-software/ci-workflows#879

Summary

Registers the pr-review-cli.yml reusable-workflow contract at ci-workflows v0.65.6 (914264587c35692c15e05c965103426eec18d1f0), so callers pinned to that release pass runner-policy.

Fix

Copies the v0.65.5 entry (@f1096608192c54cfb3dc252e36670e6f86700b9b) forward in components/runner-policy/policy.json and adds the matching copy-forward test in runner-policy.test.mjs, as #870 and #871 did. Earlier pins stay as history. gh api compare v0.65.5...v0.65.6 on ci-workflows lists three changed files; the pr-review-cli.yml patch is comment-only (ci-workflows#879: a cost decision carries no further once a pull request comment was deleted since its hold marker), so inputs, secrets and permissions are unchanged.

Verification

  • node components/runner-policy/runner-policy.mjs --root <worktree>: Runner policy passed.
  • node --test components/runner-policy/runner-policy.test.mjs: 348 tests, 348 pass, 0 fail.

Related

🤖 Generated with Claude Code

…contract

Copies the v0.65.5 entry forward with a copy-forward test, as #871 did.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kyle-sexton
kyle-sexton marked this pull request as ready for review October 24, 2026 15:13
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-24T15:15:33.174790Z e1c7463 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

claude-security-review reviewed e1c7463e86d72af2ee51fd59485ab500074dfe25: 0 finding(s), 0 as inline comments.

No security issues found in PR #874 (head e1c7463).

Scope: The PR changes two files, components/runner-policy/policy.json and components/runner-policy/runner-policy.test.mjs. It adds an approved-reusable-workflow contract for pr-review-cli.yml at ci-workflows v0.65.6 (914264587c35692c15e05c965103426eec18d1f0).

Checks:

  • The new entry is a verbatim copy of the v0.65.5 entry (f1096608…), which I compared line by line. It has the same hosted-only routing, the same fixedRunsOn of ubuntu-24.04, the same 11 allowed inputs and the same two REVIEWS_* secret mappings.
  • It adds no input, no secret and no runner. The allowlists stay as narrow as before, and the entry is keyed by a full 40-character commit SHA, so it is pinned.
  • The added test asserts that the new entry deep-equals the v0.65.5 entry and that exactly one key exists for the new SHA. That guards against drift.
  • The diff touches no trust-gate path (trusted-actors, check-trusted-trigger, CODEOWNERS, .gitmodules). It also touches no plugin manifest and removes or softens no standing instruction.

Not verified: I could not confirm that 914264587c35… is the commit the v0.65.6 tag points to. The tag lookup against ci-workflows needed approval that wasn't available. The claude-lanes-repin lane or the convergence tests in this repo are the places that check pin provenance.

critical-findings: 0

@github-actions

Copy link
Copy Markdown

claude-review reviewed e1c7463e86d72af2ee51fd59485ab500074dfe25: 0 finding(s), 0 as inline comments.

No findings.

The PR adds a pr-review-cli.yml@914264587c35… (v0.65.6) contract to components/runner-policy/policy.json. I compared it with the v0.65.5 entry (@f1096608…) and the routing, fixedRunsOn, 11 allowedInputs and both allowedSecrets match. The new runner-policy.test.mjs test asserts exactly this and checks that only one entry exists for the new SHA. It follows the existing copy-forward tests.

I did not run the test suite or the runner-policy check. The Verification section's results are author-claimed and unverified by me. I did not check ci-workflows v0.65.6's actual workflow inputs, so the claim that its changes are comment-only is also author-claimed.

The PR body follows the contract: a Refs: line plus Summary, Fix, Verification and Related sections. It names no closing issue, so there are no acceptance criteria to check. No hold class applies. The change adds no model spend, doesn't touch trusted-actors, CODEOWNERS or .gitmodules, and has no critical security issue.

@kyle-sexton
kyle-sexton merged commit b723e2b into main Oct 24, 2026
24 checks passed
@kyle-sexton
kyle-sexton deleted the feat/runner-policy-v0.65.6 branch October 24, 2026 15:19
kyle-sexton added a commit that referenced this pull request Oct 24, 2026
…contract (#876)

Refs: melodic-software/ci-workflows#880

## Summary

Registers the `pr-review-cli.yml` reusable-workflow contract at
ci-workflows
[v0.65.7](https://github.com/melodic-software/ci-workflows/releases/tag/v0.65.7)
(`4c531cea137f5cbb38d4c132dbfa6e38f76fba7d`). Callers pinned to that
release then pass runner-policy.

## Fix

Copies the v0.65.6 entry (`@914264587c35692c15e05c965103426eec18d1f0`)
forward in `components/runner-policy/policy.json` and adds the matching
copy-forward test in `runner-policy.test.mjs`, as #874 did. Earlier pins
stay as history. `gh api compare v0.65.6...v0.65.7` lists seven files.
In `pr-review-cli.yml`, only the compose prompt, the hold step's env and
comments change. The `hold-paths` input stays, so inputs, secrets and
permissions are unchanged. The change itself is
[ci-workflows#880](melodic-software/ci-workflows#880):
`hold-paths` becomes extra security scrutiny instead of a hold, and a
cost hold needs a real charge.

## Verification

- `node components/runner-policy/runner-policy.mjs --root <worktree>`:
Runner policy passed.
- `node --test components/runner-policy/runner-policy.test.mjs`: 349
tests, 349 pass, 0 fail.

## Related

-
[melodic-software/ci-workflows#880](melodic-software/ci-workflows#880)
(the fix released as v0.65.7)
- #874 (the v0.65.6 contract)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
kyle-sexton added a commit that referenced this pull request Oct 24, 2026
…contract (#877)

Refs: melodic-software/ci-workflows#882

## Summary

Registers the `pr-review-cli.yml` reusable-workflow contract at
ci-workflows
[v0.65.8](https://github.com/melodic-software/ci-workflows/releases/tag/v0.65.8)
(`4f79cc9244498ae856504cf74aeeb05dcc9c6b43`), so callers pinned to that
release pass runner-policy.

## Fix

Copies the v0.65.7 entry (`@4c531cea137f5cbb38d4c132dbfa6e38f76fba7d`)
forward in `components/runner-policy/policy.json` and adds the matching
copy-forward test in `runner-policy.test.mjs`, following #874 and #876.
v0.65.8
([ci-workflows#882](melodic-software/ci-workflows#882))
adds a `check-key-credit` job that skips the key job while the key's
recent credit stop is inside `key-credit-window-hours`. Callers pass no
new input. They grant `actions: read` on the calling job, which the
contract does not record. Inputs, secrets and runner are unchanged.

## Verification

- `node components/runner-policy/runner-policy.mjs --root <worktree>`:
Runner policy passed.
- `node --test components/runner-policy/runner-policy.test.mjs`: 350
pass, 0 fail.

## Related

-
[melodic-software/ci-workflows#882](melodic-software/ci-workflows#882)
(released as v0.65.8)
- #876 (the v0.65.7 contract)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant