test: fix referer check on msedge, drop persistent OPFS test by yury-s · Pull Request #42570 · microsoft/playwright

Yury Semikhatsky (yury-s) · 2026-09-04T21:56:54Z

Summary

Compare Chromium major version in the custom referer test; Edge's build number made the full-version check misclassify msedge-dev.
Remove the persistent-context OPFS round-trip test that fails on WebKit Windows.

Edge's third version component is its own build number, so comparing the full version against 154.0.8014.0 misclassified msedge-dev as an old build. Compare the major version instead. Remove the persistent-context OPFS round-trip test that fails on WebKit Windows; persistent contexts are not a meaningful storage state scenario.

github-actions · 2026-09-04T23:25:58Z

Test results for "tests 2"

2 failed
❌ [chromium-page] › page/page-set-extra-http-headers.spec.ts:65 › should not duplicate referer header @msedge-dev-windows-latest
❌ [webkit-page] › page/page-leaks.spec.ts:136 › expect should not leak @webkit-macos-15-xlarge

31 flaky

⚠️ [chromium-library] › library/chromium/chromium.spec.ts:301 › should report intercepted service worker requests in HAR `@chrome-ubuntu-22.04`
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1695 › should highlight locator in iframe while typing `@chromium-macos-15-large`
⚠️ [chromium-library] › library/chromium/oopif.spec.ts:179 › should take screenshot `@chromium-macos-14-xlarge`
⚠️ [chromium-library] › library/chromium/oopif.spec.ts:179 › should take screenshot `@chromium-macos-15-xlarge`
⚠️ [chromium-library] › library/beforeunload.spec.ts:130 › should support dismissing the dialog multiple times `@chrome-beta-ubuntu-22.04`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:373 › should produce network events, routing, and annotations for Service Worker `@chrome-beta-ubuntu-22.04`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:373 › should produce network events, routing, and annotations for Service Worker `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:110 › selector generator › should use description from aria-describedby `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:272 › selector generator › should use readable id `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:673 › selector generator › should generate noText: no text engine `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:693 › selector generator › should generate noText: ignore aria-labelledby pointing inside the element `@chrome-macos-latest`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@tracing-firefox`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@tracing-firefox`
⚠️ [firefox-page] › page/page-emulate-media.spec.ts:144 › should keep reduced motion and color emulation after reload `@tracing-firefox`
⚠️ [firefox-page] › page/page-event-request.spec.ts:181 › should return response body when Cross-Origin-Opener-Policy is set `@tracing-firefox`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-macos-15-large`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-macos-15-large`
⚠️ [firefox-page] › page/page-event-request.spec.ts:181 › should return response body when Cross-Origin-Opener-Policy is set `@firefox-macos-15-large`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-windows-latest`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-windows-latest`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-macos-15-xlarge`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-macos-15-xlarge`
⚠️ [firefox-library] › library/defaultbrowsercontext-1.spec.ts:89 › should support viewport option `@firefox-macos-15-xlarge`
⚠️ [firefox-library] › library/trace-viewer.spec.ts:1915 › should not leak recorders `@firefox-macos-15-xlarge`
⚠️ [firefox-page] › page/page-goto.spec.ts:90 › should work with Cross-Origin-Opener-Policy `@firefox-macos-15-xlarge`
⚠️ [webkit-library] › library/inspector/cli-codegen-java.spec.ts:114 › should print the correct imports in junit `@webkit-windows-latest`
⚠️ [webkit-library] › library/trace-viewer-scrub.spec.ts:157 › should update scrubber aria-valuenow `@webkit-macos-15-xlarge`
⚠️ [webkit-library] › library/tracing.spec.ts:533 › should produce screencast frames fit `@webkit-macos-15-xlarge`
⚠️ [webkit-library] › library/video.spec.ts:113 › screencast › should capture static page `@webkit-macos-15-xlarge`
⚠️ [android-page] › page/locator-click.spec.ts:20 › should work Radoslav Kirilov (@smoke)
⚠️ [android-page] › page/selectors-frame.spec.ts:203 › should click in lazy iframe

110638 passed, 4723 skipped

Merge workflow run.

github-actions · 2026-09-04T23:36:56Z

🔴 One failure is caused by this PR

Hi, I'm the Playwright bot and I took a look at the failing CI on this PR.

The referer-check change breaks page-set-extra-http-headers.spec.ts:65 on msedge-dev-windows-latest — the exact test and browser this PR is retargeting. msedge-dev is Chromium major 154 but a build before 154.0.8014.0, so it still emits the duplicated referer header; swapping the build-number gate for browserMajorVersion < 154 drops the it.fail gate and the real duplication now fails the test. The other failure (page-leaks on WebKit) is a known cross-run flake.

Details

Two 2 failed in the "tests 2" report (run 33929183617); "tests 1" and "MCP" were clean. Overall: 🔴 red.

Caused by this PR

[chromium-page] › page/page-set-extra-http-headers.spec.ts:65 › should not duplicate referer header @msedge-dev-windows-latest — this is the test the PR edits, on the browser the PR targets. In the aggregated results, on main and this PR's earlier commits, msedge-dev recorded expected_status='failed' + status='passed': the old chromiumVersionLessThan(browserVersion, '154.0.8014.0') gate applied it.fail, and the browser did produce empty.html, empty.html — a correct expected-failure. The final commit replaces that with browserMajorVersion < 154; msedge-dev is major 154 (build < 8014), so 154 < 154 is false, the it.fail gate is dropped, but the browser still duplicates the header, so the assertion fails for real. The referer duplication is only fixed at 154.0.8014.0, so a major-only comparison is too coarse: it treats every 154.x build as fixed, including msedge-dev's pre-8014 one. The gate needs to stay build-number aware for msedge-dev (or gate that channel explicitly) rather than collapsing to the major version.

Pre-existing flake / infra

[webkit-page] › page/page-leaks.spec.ts:136 › expect should not leak @webkit-macos-15-xlarge — pre-existing WebKit flake. Across the results DB this test flips verdict: failed 34 of 998 runs (~3.4%), passed the other 964, on SHAs unrelated to this PR. This PR is test-only (referer tests + removing an OPFS test) and doesn't touch leak detection or WebKit, so it can't be the cause.

_{Triaged by the Playwright bot - agent run}

github-actions · 2026-09-04T23:37:08Z

Test results for "tests 1"

4 flaky

⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-event-request.spec.ts:181 › should return response body when Cross-Origin-Opener-Policy is set `@firefox-ubuntu-22.04-node20`
⚠️ [webkit-page] › page/page-leaks.spec.ts:85 › click should not leak `@webkit-ubuntu-22.04-node20`

51359 passed, 1240 skipped

Merge workflow run.

github-actions · 2026-09-04T23:37:19Z

Test results for "MCP"

8327 passed, 1371 skipped

Merge workflow run.

Pavel Feldman (pavelfeldman) approved these changes Sep 4, 2026

View reviewed changes

Yury Semikhatsky (yury-s) mentioned this pull request Sep 4, 2026

feat(webkit): roll to r2360 #42553

Merged

Yury Semikhatsky (yury-s) added the CQ1 label Sep 4, 2026

This comment has been minimized.

Sign in to view

test: use major version for referer dedup check on msedge

c3b39f0

Yury Semikhatsky (yury-s) merged commit da02274 into microsoft:main Sep 8, 2026
45 checks passed

Yury Semikhatsky (yury-s) deleted the fix-referer-edge-and-opfs-test branch September 8, 2026 22:00

Navigation Menu

Uh oh!

test: fix referer check on msedge, drop persistent OPFS test - #42570

test: fix referer check on msedge, drop persistent OPFS test#42570
Yury Semikhatsky (yury-s) merged 2 commits into
microsoft:mainfrom
yury-s:fix-referer-edge-and-opfs-test

Yury Semikhatsky (yury-s) commented Sep 4, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

github-actions Bot commented Sep 4, 2026

Uh oh!

github-actions Bot commented Sep 4, 2026

Uh oh!

github-actions Bot commented Sep 4, 2026

Uh oh!

github-actions Bot commented Sep 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Yury Semikhatsky (yury-s) commented Sep 4, 2026

Summary

Uh oh!

This comment has been minimized.

This comment has been minimized.

github-actions Bot commented Sep 4, 2026

Test results for "tests 2"

Uh oh!

github-actions Bot commented Sep 4, 2026

🔴 One failure is caused by this PR

Uh oh!

github-actions Bot commented Sep 4, 2026

Test results for "tests 1"

Uh oh!

github-actions Bot commented Sep 4, 2026

Test results for "MCP"

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants