apparmor: validate generated profiles with apparmor_parser - #45
Merged
Merged
Conversation
thaJeztah
force-pushed
the
test_parse
branch
from
September 25, 2026 08:15
b821bbe to
ceac854
Compare
Add a helper that parses generated profiles with apparmor_parser without loading them into the kernel, and use it for golden profile tests where the referenced includes are available. This gives the tests an additional syntax/validation check beyond comparing the generated output with golden files. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
test_parse
branch
from
September 25, 2026 08:43
ceac854 to
aa2b3fd
Compare
Member
Author
|
This fails when adding this test-case; {
name: "with-special-characters",
data: profileData{
Name: `foo"bar`,
},
}, |
thaJeztah
marked this pull request as ready for review
September 25, 2026 08:43
Member
Author
|
cc @vvoland ptal |
vvoland
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a helper that parses generated profiles with apparmor_parser without loading them into the kernel, and use it for golden profile tests where the referenced includes are available.
This gives the tests an additional syntax/validation check beyond comparing the generated output with golden files.