Repository navigation
quest: import #7573, #7579, #7646 and settle time-addressing's timestamps - #7665
Merged
Merged
Conversation
…amps Plans the three open issues and records the /quest-import grill that reshaped time-addressing: every write takes a timestamp (no wall-clock stamping), legacy group IDs pass through verbatim as keys, scale-less tracks keep lite-07's Timescale 0, and moq-transport drops our Timestamp property while keeping Prior Group ID Gap as a best-effort drop signal. New m1 quests: JSON writes take a broadcast-clock timestamp (#7573), catalog delay is the minimum trail (#7579), a lapsed request token resets with EXPIRED_AUTH_TOKEN (#7646 point 1), and @moq/net group IDs past 2^53. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
This run was cancelled before it finished. |
This was referenced Nov 3, 2026
kixelated
commented
Nov 3, 2026
kixelated
left a comment
Collaborator
Author
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 1ad01fa
quest/m1/time-addressing/model.md:101–108: Legacy publishers may retain sequential group IDs even when frame PTS uses milliseconds, butquest/m1/time-addressing/consumers.mddirects HLS/DASH export to place groups by group start rather than first-frame PTS. Those IDs are not presentation timestamps, so the two plans can place legacy segments at incorrect times or collide on the grid. Preserve frame-PTS placement when keys are not known timestamps, or specify an equivalent mapping, and cover legacy ingest in export tests.
The explicit key/clock distinction is a useful direction; aligning the consumer plan with it is simpler than assuming all retained keys are timestamps. Static review only; I did not run tests.
kixelated
added a commit
that referenced
this pull request
Nov 3, 2026
Resolve conflicts with main's time-addressing rules (#7665), the finished archive epic, and subscribe-ranges' explicit ends. Datagrams keep their own sequence; the Rust child settles a scale-less datagram's timestamp. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Plans the open issues without the
questlabel (#7573, #7579, #7646). It also records a/quest-importgrill that reshaped how time-addressing handles timestamps. Each issue is closed by the PR that finishes its quest, not by this one.New m1 quests
moq_publish_catalog_now(). C media then stops advertising the 8 sdelay.delaycounts B-frame reorder:Ordercompares presentation timestamps written in decode order #7579): the estimator keeps the minimum trail, so B-frame reorder never becomesdelay. No SPS depth.#7646 points 2 to 4 go to the open ietf-token-auth PR #7211. I'm passing them to that PR's sub-agent, so they aren't in this PR.
Time-addressing edits
model.md,ietf.md,lite07.md,bindings.md,js.md, plus a note inmax-age-defaults.md:Timescale 0. Their frames carry their group's key, and max-age counts bare units.Decisions (2026-11-03, maintainer, /quest-import)
now(); won't fix.delaycounts B-frame reorder:Ordercompares presentation timestamps written in decode order #7579 fix: ✅delay= minimum trail; subtract declared reorder; decode edges with SPS depth (rejected).Timescale 0: ✅ keep; drop.Review
Codex
gpt-6.1-sol(medium) viaquest review --base origin/main, head1ad01fa06cf163c2bb00c5c149e425f236f1078d: no findings.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code