Repository navigation
quest(ci): delete the stale quick-admission quest - #7756
Conversation
Quest-Claim: e34ad65e191a50c9
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
Keep normal runners at their existing admission boundaries and include the launcher in the JS selection fixture. Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
kixelated
changed the title
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The maintainer chose to drop the quick-admission implementation on 2026-11-03: cheap phases already bypass admission on main, and the recorded plan doesn't address the outer admission boundary. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Its plan marks cheap modules for `quest gate --quick`, but those phases already bypass admission; the wait happens at the outer `quest gate` around the whole run. The maintainer chose deletion over a rewrite on 2026-11-03. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
changed the title
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 2 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
kixelated
left a comment
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed head: f85a0e5.
No actionable finding in the quest deletion. The maintainer chose to drop the stale per-phase quick-admission approach; the net diff deletes that quest and its index entry, with implementation restored to base. Static GitHub inspection only; I did not run the checks.
(Written by review (OpenAI))
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Deleted
quest/m0/ci/gate-quick.md— the stale quick-admission quest is removed; its premise (cheap modules needquest gate --quick) no longer matches the admission boundary on main. - Removed its bullet from
quest/m0/ci/README.md— the CI epic's## Requiredlist no longer points at the deleted quest.
Verified the net diff against faff8e3 is exactly those two quest files (21 deletions), sh/dispatch.sh, sh/local.sh, and their tests are byte-identical to main, and no reference to gate-quick, Cheap checks skip, or gate --quick remains anywhere in the tree. This matches the existing quest-retirement pattern (e.g. #7227, #7515), and quest/m0/ci/five-minutes.md already records that admission latency belongs to quest gate upstream, so nothing is left stale.
deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) ｜ 𝕏
Problem
gate-quick planned to mark cheap modules in the dispatcher table for
quest gate --quick. Its plan no longer matches the admission boundary. On main, cheap phases already bypass admission. The historical wait comes from the outerquest gatewrapped around the whole run, and per-phase flags can't shorten it.Approach
This deletes the quest instead of implementing it.
origin/main. Thensh/dispatch.sh,sh/local.sh, and their tests are restored to main's version in a separate commit, with no history rewritten.quest rm quest/m0/ci/gate-quick.mddeletes the quest and its entry in the CI epic. It reported no other mentions.The net diff against main touches only those two quest files.
Decisions
Worth keeping
From the dropped implementation, in case someone revisits admission latency:
quest, formatters,markdown,text, and others) already run without admission. Marking them--quickadded up to 60 seconds of wait to each one. A loaded-host smoke run showed the quest/text gates waiting 60 seconds and finishing in 63/61 seconds total.sh/local.shinto a systemd scope loses exported Bash functions. The dropped change had to passdeclare -f files stepas the script, and trap TERM until the phase's children were reaped.Impact
Validation
quest check --base origin/main: passed (564 documents).sh/markdown.sh check(afterbun install --frozen-lockfile): passed.git diff --stat origin/main: onlyquest/m0/ci/README.md(one line) andquest/m0/ci/gate-quick.md(deleted).Review
Codex / GPT-6.1 Sol, medium effort, session
01a1a413-820e-7990-aa71-04923075c63f, round 1 reviewed f85a0e5b9ccf03ee845664c23c2619b21aac848b against faff8e377b20d72d28c32cca8b4135c35596f434: no findings.The previous implementation's open high-severity finding (
sh/dispatch.shadded admission to ungated cheap phases) is resolved because the implementation was dropped.Follow-ups
None. Builder namespace work stays with userns-uid-map.
🤖 Generated with Claude Code
(Written by Claude Opus 5.5)