Skip to content

docs(quest): retire the resolved binding benchmark quest - #7839

Merged
kixelated merged 6 commits into
mainfrom
quest/m0/nightly/bindings-bench-evicted
Nov 4, 2026
Merged

kixelated merged 6 commits into
mainfrom
quest/m0/nightly/bindings-bench-evicted

Conversation

@kixelated

@kixelated kixelated commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

The binding benchmark quest tracks an Evicted failure that is already fixed. The November 1 binding job failed before moq-dev/moq#7446 merged. That PR fixed the cache policy, which had shed the live group's unread frames while carrying debt for a cold victim. The November 2 and November 3 binding jobs passed.

Decisions

Settled 2026-11-04 by the maintainer:

  • ✅ Retire the stale quest: delete it with quest rm, keeping the evidence in this PR.
  • Retain it with a newer failing run or reproducer that the merged cache fix does not address.

Approach

quest rm quest/m0/nightly/bindings-bench-evicted.md deletes the quest and its Required entry in Nightly passes on main. No other document links to it. This replaces the branch's earlier rewrite of the quest's plan. The branch merges origin/main instead of rebasing.

Impact

  • Docs only: no public API, wire, benchmark, case-size, or cache-budget changes.

Validation

  • quest check --base origin/main --branch quest/m0/nightly/bindings-bench-evicted (the flake's pinned quest): 610 documents ok.
  • sh/markdown.sh check: passed.

Earlier investigation on this branch, with runtime and benchmark code unchanged from 701b7196a348ff0b9656d7db7a193673772eeb0c:

  • quest gate just gh nightly bindings passed locally, and all eight expected reports were written. Every throughput runner reported finite throughput and CPU numbers for all seven cases, including 64 KiB.
  • The 64 KiB case writes 4 MiB per round against a 64 MiB origin budget. A synchronous cache probe ran 10,000 rounds of every frame size, through cache turnover, without an eviction.

Alternatives

Changing the case size or enlarging the cache would change the measurement without a reproduced failure.

Follow-ups

None. If the 64 KiB case fails Evicted again, plan a new quest from that run.

Review

Skipped the other-vendor review for head 942a45ab3e371040484c38dbfe1452136df3947b (Claude Code, Claude Opus 5.5): the change is too trivial to need one. It is a mechanical quest rm that deletes one quest and its single Required link, as the maintainer decided on 2026-11-04. quest check --base origin/main and sh/markdown.sh check pass, and the only other change is a conflict-free merge of origin/main. Head e10897436539bc5635ebc93f5980af0b1f6e06c2 adds only a conflict-free merge of origin/main (moq-dev/moq#7840), which the review exemptions cover.

(Written by Claude Opus 5.5)

kixelated and others added 3 commits November 4, 2026 01:15
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
@kixelated kixelated changed the title The binding benchmark's 64 KiB case measures docs(quest): record the resolved binding benchmark failure Nov 4, 2026
kixelated and others added 2 commits November 4, 2026 07:29
The Evicted failure it reports was fixed by #7446, and the Nov 2 and
Nov 3 binding jobs passed, so delete the quest and its link instead of
rewriting its plan.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title docs(quest): record the resolved binding benchmark failure docs(quest): retire the resolved binding benchmark quest Nov 4, 2026
@kixelated
kixelated marked this pull request as ready for review November 4, 2026 15:31
@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The README no longer lists the 64 KiB binding benchmark case in its Required list. The related document describing an investigation into evicted failures and planned follow-up work was deleted.

Merge Risk: Minimal · up to e1089

This documentation-only cleanup presents no identified merge-blocking risk and is mergeable after normal checks.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title "docs(quest): retire the resolved binding benchmark quest" matches the change. The PR deletes the resolved binding benchmark quest document and removes its Required entry from the nightly RE…
Description check Passed The description states that the binding benchmark quest tracks an Evicted failure that was fixed by a merged PR. It explains that the quest is retired with quest rm, that its Required entry is removed…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "docs(quest): retire the resolved binding benchmark quest" matches the change. The PR deletes the resolved binding benchmark quest document and removes its Required entry from the nightly README. The raw summary confirms both file changes, and the objectives describe the same removal.

Full details: Description check

Explanation

The description states that the binding benchmark quest tracks an Evicted failure that was fixed by a merged PR. It explains that the quest is retired with quest rm, that its Required entry is removed, and that validation ran. This matches the raw summary, which shows the quest file deleted and one README line removed.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files.

Finishing Touches
Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share
Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 14f31677-987e-45db-873f-cf22b2c38671
Commits

Reviewing files that changed from the base of the PR and between 3c171db and e108974.

Files selected for processing: 2
  • quest/m0/nightly/README.md
  • quest/m0/nightly/bindings-bench-evicted.md
Files with no reviewable changes: 1
  • quest/m0/nightly/bindings-bench-evicted.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • Quest deleted — quest/m0/nightly/bindings-bench-evicted.md is removed; the 64 KiB Evicted failure it tracked was fixed by #7446.
  • Parent link removed — the quest's only Required bullet is dropped from quest/m0/nightly/README.md.
  • Merges from main — two conflict-free merge commits carry no additional changes.

A repository-wide search finds no remaining references to bindings-bench-evicted, so the removed Required link was the only inbound one. The change is docs-only and does not touch the benchmark runners, case sizes, or cache budgets.

Pullfrog  | View workflow run | Using deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed head e108974 against base 3c171db. No actionable findings. Removing the resolved benchmark quest and its parent link follows the recorded maintainer decision.

The November 1 binding job failed before #7446 merged; the linked November 2 and 3 binding jobs passed. The change does not alter benchmark sizes or cache policy, and the merged cache fix remains on the base.

Verification: GitHub-only static review of the quest, fix and linked job evidence, including an independent pass. I did not run the binding benchmarks or quest checks.

(Written by review (OpenAI))

@kixelated
kixelated added this pull request to the merge queue Nov 4, 2026
Merged via the queue into main with commit 08ab033 Nov 4, 2026
8 of 9 checks passed
@kixelated
kixelated deleted the quest/m0/nightly/bindings-bench-evicted branch November 4, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant