Repository navigation
fix(net): expect bounded EOF in range widening benchmark - #7840
Conversation
Quest-Claim: 758cb1dd82a1de66
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
kixelated
changed the title
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 9 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
kixelated
left a comment
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed head f5fad75.
No actionable findings. The narrowed range has already been delivered, so the bounded read returns EOF; widening the subscription reopens it. The eight-group scan and reader/cache sweep remain intact.
Verification limits: GitHub-only static inspection of the benchmark, bounded-read behavior and quest, with an independent pass. I did not run the benchmark or test suite.
(Written by review (OpenAI))
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Corrected the bounded-EOF assertion in
bench_range_widening: the narrowed read after the widening drain now expectsPoll::Ready(Ok(None))instead ofPoll::Pending, matching #7545's bounded-read contract. The same single poll is measured, so the widening/drain workload is unchanged. - Completed the nightly quest: removed
quest/m0/nightly/track-range-widening.mdand its bullet fromquest/m0/nightly/README.md, with no remaining references anywhere in the tree.
deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) ｜ 𝕏
- bench-test-mode: Nightly's "Rust bench targets" already runs moq-net's Criterion targets measured and failed on origin, session, memory and track (run 41656613559); #7729 and #7840 merged; origin and session need `fuzz`; where CI catches the next break is left to the maintainer, since a gate run reverses the Nightly epic's 2026-10-24 decision. The Nightly epic now names this quest as the owner of those panics. - reload-close-drain: #7090 named the failing case. - agent-disk-budget: note `quest worktree`, which docs/mbx.md points to. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Problem
track_range_widening/1r/64panics on main because it expects a narrowed, already exhausted bounded read to stay pending. Bounded reads end once their requested groups have been delivered.Approach
Assert
Ready(Ok(None))after narrowing back to the delivered0..1range. Preserve the widening and drain loop, its eight-group cached span, and the full reader/cache sweep. Complete and remove quest/m0/nightly/track-range-widening.md and its Nightly epic link.Impact
Alternatives
The quest authorizes either asserting EOF or changing the narrow range to keep it unfinished. Choose EOF: this benchmark measures scanning the newly covered cached span, so keeping its existing ranges preserves the measured workload. This respects the same bounded EOF and reopening contract as moq-dev/moq#7837, whose production fix does not change this benchmark. No maintainer decision remains open.
Validation
d66c8928339d51eb4c76925ced1490b37a0ec9be:quest gate cargo test -p moq-net --bench track -- track_range_wideningexits 101 attrack_range_widening/1r/64, failing the pending assertion.quest gate cargo test -p moq-net --all-targets: passes, 3,388 tests and 608 benchmark smoke cases, including all nine widening cases; 13 existing ignored tests.quest gate cargo bench -p moq-net --bench track -- track_range_widening --sample-size 10 --warm-up-time 0.05 --measurement-time 0.1 --noplot: passes all nine cases. This is a completion check, with no performance claim.quest gate just ci: passes, including all 3,388 selected Rust tests, lints, docs, and repository checks. Neither reported shared base failure occurred in this run.quest check --base origin/main: 612 documents valid.git diff HEAD --check: passes.quest contextas unknown; followedquest guideas directed by the task.Review
GPT-6.1 Sol, xhigh effort, local self-review of head
f5fad754b097154559f1821ceaadc82ae1243cf0: no findings. Checked the bounded exhaustion and range-update paths and confirmed the widening workload is unchanged. Independent review skipped under quest's trivial-change exemption: one assertion correction, one explanatory comment, and completed-quest removal. No reviewer sub-agent was started.Follow-ups
None.
(Written by GPT-6.1 Sol)