Repository navigation
chore: release - #7936
chore: release#7936
Conversation
kixelated
left a comment
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: b650028
No actionable findings. Relay and CLI versions, workspace requirements, lock entries and changelogs are consistent; the dependency refresh follows the existing release configuration. The narrow patch release is appropriate to the backport described.
Verification: GitHub-only static review. I did not run builds, tests or registry validation; exact-head jobs were queued or running when inspected.
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Version bump for
moq-relay:0.17.12→0.17.13, with the changelog crediting the HTTP response and ops-listener hardening backport. - Version bump for
moq-cli:0.14.12→0.14.13, tracking its dependency onmoq-relay. - Workspace dependency update: root
Cargo.tomlmovesmoq-relayto0.17.13;moq-cliinherits it viaworkspace = true. - Regenerated
Cargo.lock: matching package versions plus compatible transitive bumps (toml1.2.0,toml_edit0.25.18,winnow1.0.5,moq-vaapi0.1.1), consistent with.release-plz.tomldependencies_update = true.
I verified the changelog claim against the release branch: beeb23df7 (merged in #7920) is present, so the note is accurate. Version strings match between Cargo.toml, CHANGELOG.md, and Cargo.lock, no other crate pins moq-relay at an explicit version, and the dependency constraints (toml = "1.1", moq-vaapi = "0.1.0") still admit the resolved versions.
deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) ｜ 𝕏
b650028 to
e6295c2
Compare
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
Reviewed the delta from b650028cc to e6295c213, which is a rebase onto the newer release branch plus a wider release-plz regeneration.
- Release scope widened from 2 to 25 crates:
moq-net 0.3.21now carries the "withdraw IETF advertisements without send credit" fix, and every published crate that (transitively) depends on a bumped crate got a patch bump with a "updated the following local packages" changelog entry. moq-relay 0.17.13retained: the HTTP response / ops-listener hardening backport note is still accurate for this release.- Workspace and per-crate manifests: all root workspace dep versions and each crate
Cargo.tomlversion match the new release, includingmoq-cli,moq-ffi,libmoq,moq-gst, andmoq-room. Cargo.lockregenerated: the diff is now onlyname/versionlines; the incidental transitive bumps from the first revision are gone.
I checked every crate version against the root workspace deps, Cargo.lock, and the latest CHANGELOG.md heading, and confirmed that every published crate depending on a bumped crate was itself bumped (only the publish = false moq-bench and moq-wasm are excluded). cargo metadata --locked --offline --no-deps succeeds, and the PR body release list matches the 25 bumped crates exactly.
(Written by DeepSeek V4.1 Flash 1017)
deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) ｜ 𝕏
e6295c2 to
9efcf3f
Compare
kixelated
left a comment
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 9efcf3f
Base: dc3478a
No actionable findings. Compared with my previous review of b650028, this expands the release from 2 to 25 crates and refreshes dependencies. All 25 crate versions agree with their lock entries, changelog headings, PR release list and applicable workspace requirements. The dependency refresh follows the existing release-plz configuration; there were no prior findings to carry forward.
Direction: the generated patch-release approach remains appropriate. The diff against the current release base contains only release metadata and dependency updates, with no new source-level API or wire changes.
Verification: GitHub-only static review. I did not run builds, tests or registry validation. Exact-head Check and the latest Release gate workflows were still running when rechecked.
(Written by OpenAI)
There was a problem hiding this comment.
ℹ️ No critical issues. One release-notes gap inline.
Reviewed changes
Reviewed the delta from e6295c2 to 9efcf3f, where the branch picked up the new release tip and release-plz regenerated.
- Base advanced to the joined-head backport:
dc3478a86merged #7680'smoq-netcache-miss FETCH race fix intorelease, so those fixes ship in this cut. - Regenerated
moq-netchangelog:0.3.21only gained an### Otherline recording the merge commit, with no### Fixedentries for the shipped fix commits. - Lockfile refreshed again:
enum-assoc1.4.2,futures-buffered0.2.14 (now pullingfixedbitset0.5.7),generator0.8.12,mime0.3.18,winnow1.0.5,toml_edit0.25.18, plus a secondwindows-core/windows-link/windows-result/windows-strings0.100.0 family alongside 0.62.2.
I re-checked version consistency at this head: every root workspace dep matches its crate's Cargo.toml, every Cargo.lock package version matches its crate, every bumped crate's latest CHANGELOG.md heading matches its version (only pre-existing moq-v4l differs, untouched here), and cargo metadata --locked --offline --no-deps succeeds. CI at this head was still running; the failing Release gate is the sibling-workflow gate, not a build or test failure.
deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) ｜ 𝕏
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
left a comment
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: a50cda6
No actionable findings in the delta since 9efcf3f. The only change replaces merge noise in moq-net's 0.3.21 changelog with the joined-head FETCH and PUBLISH_DONE-grace fixes. Both descriptions match the implementation already merged into the release base by #7680, addressing the release-notes gap raised in the intervening review.
Direction: keep this focused changelog correction. No implementation, API, wire, or version changes were added in this round.
Verification: GitHub-only static comparison against the previous reviewed head and merged backport. No builds or tests run; exact-head Check is running and Release gate is pending.
(Written by OpenAI)
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
Reviewed the delta from 9efcf3f96 to a50cda650, a single docs commit on release-plz-2026-11-05T06-34-53Z.
moq-net 0.3.21release notes completed:rs/moq-net/CHANGELOG.mdnow lists the shipped joined-head cache-miss fixes under### Fixed: "wait for the joined group head before fetching a cache miss" (2da1f4bfc) and "keep cache-miss fetches moving through the PUBLISH_DONE grace" (87e8ef9c8, named from its commit body).- Merge-commit noise removed: the
### Otherentry forc59489c5d("Merge remote-tracking branch 'origin/release' into HEAD") is gone, so the section is now just the three real fixes.
I checked both new entries against the commits merged by #7680 (dc3478a86), which are ancestors of this head but not of the pre-#7680 base, so they do ship in this cut. 351a7523f ("read the fill through its shared guard") is not named separately; it is a one-line internal dereference correction inside the same joined-head lifecycle and has no independent user-facing behavior, so the notes are complete for a reader. Version and lock consistency at this head is unchanged from 9efcf3f96, which I verified previously. The prior release-notes finding is addressed and its thread resolved.
CI at a50cda650 was still in progress (Scope passed; Check, Test, and the platform jobs running), so this review does not cover their outcome.
(Written by DeepSeek V4.1 Flash 1017)
deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) ｜ 𝕏
🤖 New release
moq-net: 0.3.20 -> 0.3.21 (✓ API compatible changes)moq-relay: 0.17.12 -> 0.17.13 (✓ API compatible changes)moq-json: 0.5.18 -> 0.5.19hang: 0.21.21 -> 0.21.22moq-binary: 0.1.20 -> 0.1.21moq-loc: 0.2.29 -> 0.2.30moq-mux: 0.10.21 -> 0.10.22moq-tokio: 0.19.33 -> 0.19.34moq-audio: 0.1.20 -> 0.1.21moq-video: 0.1.20 -> 0.1.21libmoq: 0.6.22 -> 0.6.23moq-archive: 0.0.21 -> 0.0.22moq-uring: 0.0.22 -> 0.0.23moq-boy: 0.5.22 -> 0.5.23moq-hls: 0.5.21 -> 0.5.22moq-stats: 0.2.22 -> 0.2.23moq-rtc: 0.3.22 -> 0.3.23moq-rtmp: 0.3.21 -> 0.3.22moq-srt: 0.3.21 -> 0.3.22moq-transcode: 0.1.20 -> 0.1.21moq-cli: 0.14.12 -> 0.14.13moq-e2ee: 0.0.21 -> 0.0.22moq-ffi: 0.4.22 -> 0.4.23moq-gst: 0.4.22 -> 0.4.23moq-room: 0.2.21 -> 0.2.22Changelog
moq-netmoq-relaymoq-jsonhangmoq-binarymoq-locmoq-muxmoq-tokiomoq-audiomoq-videolibmoqmoq-archivemoq-uringmoq-boymoq-hlsmoq-statsmoq-rtcmoq-rtmpmoq-srtmoq-transcodemoq-climoq-e2eemoq-ffimoq-gstmoq-roomThis PR was generated with release-plz.