Repository navigation
quest: Interop triage of 42245660435 (harness fixture, bare-fin async, lite-07 remeasure) - #8049
Conversation
Quest-Claim: 9b84eeccac656b06
…asure lite-07 break Triage of scheduled Interop run 42245660435. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
changed the title
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 1 minute. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
kixelated
left a comment
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed head: d0f1122
No actionable correctness findings in the four-file diff. The direction is sound: the staging fixture now includes interop-socket-js and every example in the actual build list without removing the runtime-reference coverage; the bare-fin recipe explicitly enables moq-net's optional async APIs; and the existing lite-07-wip exception is re-pinned without broadening its protocol scope. The quest correctly remains open pending a successful scheduled Interop run.
Limits: GitHub-only static review of the diff and related staging, Cargo-feature, and compatibility-harness code. I did not execute the staging or bare-fin tests, independently repeat the released-wire measurements, or verify a subsequent green scheduled Interop run. The PR's Check workflow was still in progress when inspected.
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
ℹ️ One minor suggestion inline. The three fixes themselves check out.
Reviewed changes
- Harness fixture —
test/interop/staging.test.pyderives the staged example set frominterop.sh'sexamples=(...)build list, sointerop-socket-js(built there, run only bysocket.sh) is stubbed andbuild_relay_clino longer fails on the missing artifact. bare-finfeatures —test/justfilepasses--features async, matching the async tests the recipe filters and clearing the feature-off dead-code failure seen in the run log.- Wire-compat pin —
planned-breaks.jsonre-pinsmoq-lite-07-wipto moq-cli0.14.13/ moq-relay0.17.13after a remeasure. Both are the current crates.io releases, and@moq/net0.4.7is still latest on npm, so the break will not go stale on the next run. - Quest log —
quest/m0/interop-green/README.mdrecords the 42245660435 triage and keeps the waiting item for a green scheduled run.
I confirmed against the run's job log that only the Harness, Subscription termination, and Released wire compatibility steps failed, and that the interop-socket-js cp failure is the fixture symptom the staging change fixes. The refreshed staging.test.py passes 6/6 once ffmpeg is on PATH (the two failures here were that pre-existing env requirement).
deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) ｜ 𝕏
| # Cross-language subscription termination over in-memory transports. | ||
| bare-fin: | ||
| just rs test -p moq-net --lib bare_fin_interop owed_tail_death_interop --run-ignored all | ||
| just rs test -p moq-net --features async --lib bare_fin_interop owed_tail_death_interop --run-ignored all |
There was a problem hiding this comment.
The sibling interop recipe at line 70 runs the same moq-net lib tests without --features async and only builds because selecting -p moq-crypto unifies in that crate's dev-dependency's moq-net/async; if that dev-dependency or the package selection changes, this exact failure returns there with the same misleading compile error. Naming moq-net/async there as well would make the requirement explicit instead of accidental.
Technical details
# `moq-net` lib tests need `async` in every recipe that selects them
## Affected sites
- `test/justfile:70` — `interop` runs `just rs test -p moq-net -p moq-crypto --lib ...` without `--features async`, and compiles only because `rs/moq-crypto/Cargo.toml:54` declares `moq-net = { path = "../moq-net", features = ["async"] }` as a dev-dependency, which the shared invocation unifies in. The run log shows it building `moq-net` and passing 10 tests at the same commit where `bare-fin` alone failed.
- `rs/moq-net/src/model/group.rs:5480` — `mebibytes` and its siblings are async-only test helpers that are compiled in feature-off test builds; that dead-code warning is what `build.warnings = deny` turned into the `bare-fin` failure.
## Required outcome
- Any recipe that builds `moq-net` lib tests requests the `async` feature itself rather than inheriting it from another selected package's dev-dependency.
## Suggested approach (optional)
- Add `--features moq-net/async` to the `interop` recipe's `just rs test` line (package-qualified, since `moq-crypto` also has an `async` feature).
- Optionally gate `mebibytes` behind `#[cfg(feature = "async")]`, so the feature-off config that `sh/rs/net-features.sh` compiles stays warning-free too.
|
Maintainer decision (2026-11-06, /quest-spawn): ✅ for the suggested follow-up, key the (Written by Claude Opus 5.5 with high) |
…main The Pullfrog bare-fin and staging fixes landed in #8049. A full gate on main passes except the MEMLOCK flake uring-memlock already tracks, and the CARLA, direnv hook, and supervised launcher tests pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Triage of scheduled Interop run 42245660435 (at 01d4edb, which predates moq-dev/moq#8001, so P2P was not tested with that fix). No media-matrix, P2P, or IETF22 fallback failure; three deterministic steps failed, each fixed here:
test/interop/staging.test.pystubbed only examplesinterop.shruns directly;interop-socket-jsis built there but run only bysocket.shsince moq-dev/moq#7884. The fixture now stubs every example in the build list.just test bare-fin): built moq-net lib tests without theasyncfeature the tests need, a configuration nothing else compiles, so dead code broke it (read_framethen,mebibytesunused now on main). The recipe now passes--features async; locally 3/3 pass.moq-lite-07-wipplanned break stale; remeasured withjust test wire-compat --remeasure(same 16 cells fail), andjust test wire-compatpasses.The quest stays in place with its
## Waitingitem: it finishes when a scheduled Interop run passes.Review
Codex (gpt-6.1-sol, medium) reviewed head d0f1122 against origin/main: no findings.
Validation
python3 test/interop/staging.test.py: 6 tests OKjust rs test -p moq-net --features async --lib bare_fin_interop owed_tail_death_interop --run-ignored all: 3/3 passjust test wire-compat: passed after remeasurequest check: okSuggested follow-ups
moq-lite-07-wipplanned break goes stale on every moq-cli/moq-relay release and reds Interop each time; consider pinning it to the draft rather than release versions, or remeasuring as part of the release.🤖 Generated with Claude Code
(Written by Claude Opus 5.5)