Repository navigation
test(interop): the invalid-attribute check tests lookahead, not the renamed buffer - #8168
Conversation
Quest-Claim: ff96dd6e1d90829f
…enamed buffer Scheduled Interop run 42382888974 failed only on this stale case. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
changed the title
|
Maintainer decision (2026-11-07, /quest-complete):
The Waiting item asking to close #8148 is removed; the Interop-run wait stays. (Written by Claude Opus 5.5 with high) |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 18 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
kixelated
left a comment
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed head 9715699 against base 76bb38f. No actionable findings.
The invalid-value case now targets the actual lookahead attribute and setter, while the new buffer case separately verifies the rename error and recovery on removal. These assertions match the element's invalid-attribute bookkeeping and connected-state recovery. Removing the completed narrow quest while keeping the broader interop quest open is consistent with the scope.
Direction: retain both checks, since invalid lookahead values and obsolete buffer markup are distinct contracts.
Verification limits: GitHub-only static inspection of all four changed files and the relevant element parsing, setter and recovery paths. No browser, Bun, lint or quest checks run; the reported 17 passing tests were not independently reproduced. Rechecked state, full head/base and reviews immediately before posting.
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
lookaheadreplaces the stalebuffercase —"30"is a bare non-zero duration thatparseLookahead(viaparseDuration) rejects, and thelookaheadproperty setter rejects the string while0clears the invalid state.- New
bufferrename check — asserts the old attribute reports the rename tolookaheadand the element re-enables once the attribute is removed. - Quest bookkeeping — deletes the completed child quest and its index row, and records the triage of scheduled Interop run 42382888974 in the interop-green quest.
I confirmed run 42382888974 failed only this test (attribute: "buffer", threw: false, recovered: false) and ran the updated test locally: it passes. No public API or wire change.
deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) ｜ 𝕏
Summary
Triages scheduled Interop run 42382888974 (2026-11-07). The earlier runs' failures were already fixed: 42245660435 by moq-dev/moq#8049, and 42062226837's P2P failure by moq-dev/moq#8001. Its fallback audio stall belongs to the IETF22 fallback quest.
42382888974 failed only one step, Harness regressions. In it,
publish-ui.browser.ts's "invalid attributes and properties refuse, retain bad markup, and recover" still tested moq-watch'sbuffer, which moq-dev/moq#8057 renamed tolookahead.That case now tests
lookaheadwith"30", a bare numberparseLookaheadrefuses.A new check confirms that a
bufferattribute reports its rename and the element recovers once it is removed.The quest records this triage. It stays open on main: its own `## Checks
bun test ./publish-ui.browser.ts: 17 passbiome check: cleanquest check --base origin/main: ok (after mergingorigin/main)Public API: none. Wire: none.
🤖 Generated with Claude Code
(Written by Claude Opus 5.5)
Review
Rewritten by
quest reviewafter each round.01a1b831-f644-7b82-9260-87e53b8c8937, round 1The updated case matches the implemented lookahead validation and covers rejection and recovery of the renamed buffer attribute, with no actionable defects found by source inspection; builds and tests were not run.