Repository navigation
test(net): quarantine the lite-07 datagram queue test and plan its fix - #8379
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Test quarantined:
js/net/src/lite/datagram-tracks.test.ts's lite-07createWritabledatagram queue test becomestest.skipwith a// Quarantined: flaky under load, see /quest/m0/test-flakes-2/datagram-queues.mdcomment, matching the wording and comment style of the other quarantines injs/net. - Follow-up quest added:
quest/m0/test-flakes-2/datagram-queues.mdis a 25-line XS child whose Plan reproduces the failure under load first, then replaces the immediate two-queue assertion with a wait on the event that creates the first track's send queue, with a note to decide whether early delivery on the second track is itself a bug. - Epic index updated: the quest joins the existing m0 test-flakes epic with one
## Requiredbullet, appended in the same format as its siblings.
The plan's suspected cause holds up against the code: the test waits for the publisher's datagrams.priority to reach 19, but nothing orders the server-side createWritable send queue before it asserts pair.server.sendStreams.datagrams has two entries. The test body is unchanged on current main, so the quarantine is still warranted, and no duplicate child exists there.
deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed head: c087bcf
No actionable findings. The change disables only the identified test, links its follow-up from both the test and the epic, and leaves production behavior unchanged. The plan appropriately treats the queue-ordering explanation as unconfirmed and calls for reproduction before choosing a test or publisher fix.
Verification: GitHub-only static review of all three changed files, repository guidance, related quarantine history, and the publisher/datagram-writer/mock paths. I did not run tests, reproduce the flake, or run quest checks; the head's Check workflow was still in progress when inspected.
|
No actionable comments were generated in the recent review. WalkthroughThe lite-07 datagram queue test is now skipped. The work list calls for waiting for the first track’s queue and removing the skip. A new plan records a suspected race after Merge Risk:
|

Quarantines js/net's "lite-07 bounds and prioritizes independent createWritable datagram queues" test and plans its fix as js/net's lite-07 datagram queue test holds up under load. This was the follow-up moq-dev/moq#8276 suggested. The test failed once in a full
just checkon that branch and passed 8 of 8 times alone. The suspected cause is that it asserts two send queues exist right after the second track's first datagram, before the first track's queue is sure to exist.The repository's rule is to disable a flaky test immediately and plan a follow-up, so the test is
test.skipped with a comment naming the quest, as the epic's other quarantines are.Decisions
Impact
Test and quests only. Public API: none. Wire: none.
Checks
bun test src/lite/datagram-tracks.test.ts(36 pass, 4 skip), biome on the file, andquest checkpass.Models
Size: XS
Implementer: Claude Code, claude-opus-5-5, high effort
🤖 Generated with Claude Code
(Written by Claude Opus 5.5 with high effort)
Review
Rewritten by
quest reviewafter each round.01a1c193-e502-70c1-b7a3-1fb933ab7236, round 1The change quarantines a flaky test and records a linked investigation plan as repository policy requires, without changing runtime behavior or introducing actionable defects.