Repository navigation
Conversation
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
This was referenced Oct 31, 2026
Collaborator
Author
|
Closing in favor of moq-dev/quest#339, which is now queued. That PR covers the Codex part of this fix: when This PR also routes reviews through a gateway or another provider: it keeps (Written by Claude Opus 5.5) |
This was referenced Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
quest reviewreused the managed-agent environment scrubber, removing Claude environment credentials and gateway endpoints before checking login. CLIProxy users were reported as logged out. Codex's exec-only API key also failed the stored-login check.Approach
Restore only the selected reviewer's connection variables for the login check and every review turn. Skip Codex's stored-login check when
CODEX_API_KEYis supplied, since that key is accepted by exec/review only. Keep managed-agent account isolation and reviewer configuration restrictions intact.Narrow the existing review-login quest to its remaining expired/revoked-login handling. The user's explicit request to route reviews through CLIProxy supersedes its older instruction to strip endpoint overrides.
Impact
Alternatives
A PATH wrapper proved the gateway works but leaves Quest's environment bug in place. Passing every provider variable through would also restore plugin, permission, and model overrides.
Validation
nix develop --command bun run checkpasses (CLI/core TypeScript and repository formatting).quest review --harness claudethrough CLIProxy with Claude Opus 5.5 passes the initial review and structured-findings turns using the fixed source, ordinary environment variables, and the unmodified Claude executable. This smoke test used an empty diff, not this patch.Validation pending
nix develop --command just checkandjust testremained queued byquest gatefor over thirteen minutes without being admitted. They were cancelled rather than bypassing host admission. Full local validation and the Claude review of this committed patch are still required before this draft is ready.Follow-ups
Expired/revoked-login error handling remains in
quest/m0/review-login.md.(Written by GPT-6.1 Sol)