Skip to content

chore(quest): plan Ed25519 verify without ADX and a per-host bench lock - #401

Merged
kixelated merged 1 commit into
mainfrom
quest/bench-followups
Nov 6, 2026
Merged

kixelated merged 1 commit into
mainfrom
quest/bench-followups

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Plans the two follow-ups moq-dev/rind#397 found, as the maintainer asked:

  • quest/m2/speed/ed25519-no-adx.md [M]: Ed25519 verification is 1.3x RustCrypto's time on the new OVH VPS hosts, whose virtual CPUs hide ADX.
  • quest/m2/speed/bench-host-lock.md [XS]: admin/bench-report collect takes a per-host lock on every host, after one session's collection clobbered another's on kixtop.

quest check passes.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@pullfrog

pullfrog Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Your OpenCode Go account is out of credit. Top it up, then re-trigger Pullfrog.

OpenCode Go's response
provider error: Insufficient account funds

Top up OpenCode Go →

Pullfrog  | Rerun failed job ➔ | View workflow run | via Pullfrog | Using glm-5.3

@coderabbitai

coderabbitai Bot commented Nov 6, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 55 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a7bb6286-21b1-44f5-b7d1-1ea0f851b2a5
Commits

Reviewing files that changed from the base of the PR and between 61da4fd and 2a830d8.

Files selected for processing: 3

  • quest/m2/speed/README.md
  • quest/m2/speed/bench-host-lock.md
  • quest/m2/speed/ed25519-no-adx.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated
kixelated enabled auto-merge November 6, 2026 18:57

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed head: 2a830d8

No actionable findings in these three planning-only files. The new quest links resolve, the Ed25519 goal follows the repository's performance/verification policy, and #397's raw VPS results support the stated 1.3× RustCrypto baseline. The lock goal addresses the existing collector's destructive copy-before-busy-check ordering.

Direction: proceed with these follow-up plans; review the eventual implementations separately, including cross-platform locking and no-ADX performance evidence. The referenced VPS support currently remains in open PR #397 rather than this branch.

Verification limits: GitHub-only static review of the complete diff, related collector code, policy, discussions, and benchmark data. I did not run quest check, tests, or remote benchmarks.

@kixelated
kixelated added this pull request to the merge queue Nov 6, 2026
Merged via the queue into main with commit 6eafc6e Nov 6, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant