Repository navigation
feat(rind-ring): patch ring from moq-dev/rind-patch, without rind's test vectors - #456
Merged
Merged
Conversation
Quest-Claim: c62a170bafa94d32
…est vectors The ring shim moves from patch/ring to moq-dev/rind-patch, where it depends on the published rind-ring, so a binary's [patch.crates-io] line no longer clones rind's ~150 MB of test-vector submodules. sh/patch.sh runs the fixture through that shim with rind-ring patched to the checkout, so a rind-ring change still runs through it before release. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
marked this pull request as ready for review
November 7, 2026 06:42
|
Your OpenCode Go account is out of credit. Top it up, then re-trigger Pullfrog. OpenCode Go's response
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 13 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Finishes quest/m2/adoption/aws-lc-rs/patch-repo.md, following moq-dev/rind#444.
Summary
The
ringpatch shim moves from rind'spatch/ringto moq-dev/rind-patch (initial commit), where it depends on the publishedrind-ring = "0.17"instead of by path. A binary now patches withand Cargo clones a few KB instead of rind's ~150 MB of test-vector submodules.
ring/as its only member (the aws-lc-rs shim joins as a second member), a README,LICENSE-APACHE,LICENSE-ISC, andLICENSE-MIT-0, and aBuildworkflow that runscargo fmt --checkandcargo clippy --deny warningsagainst crates.io. ItsCargo.lockis ignored, since a patching binary's own lockfile governs.patch/fixturepatches ring from rind-patch, as the docs say.sh/patch.shalso patches rind-ring to this checkout, so a rind-ring change runs through the shim before its release. It then checks that ring resolves only to rind-patch's shim and rind-ring only to the checkout. When rind-ring moves past ring 0.17, the shim's0.17requirement no longer matches the checkout, so the check fails until rind-patch follows.ring v0.17.999comes "from rind-patch".Public API
No crate API changes. The documented git route changes:
ring = { git = "https://github.com/moq-dev/rind" }no longer finds aringcrate, sincepatch/ringis gone. That line reachedmainonly in #444 and was never in a release, so the title has no!. A!would also make release-plz propose rind-ring 0.18 (CONTRIBUTING.md's Releases). To migrate, swapmoq-dev/rindformoq-dev/rind-patchin the patch line and runcargo update -p ring.Choices made without asking
ring/is a workspace member rather than the root package, so the aws-lc-rs shim can sit beside it without a restructure.Copyright 2026 The rind Authors, since the shim is new code with no third-party source.mainon each run (cargo generate-lockfile), as a binary adding the patch today would.Caused by
None. This finishes the plan #444 recorded, rather than fixing a defect in it.
Validation
nix develop --command just check: passes, includingsh/patch.sh, which ran the QUIC handshake through rind-patch@9a0a884 with this checkout's rind-ring.quest check --base origin/main: 146 documents ok.cargo clippy --workspace --all-features -- --deny warningspasses with rind-ring patched to rind's checkout, andactionlintis clean. Against crates.io it fails to resolverind-ring = "^0.17"until moq-dev/rind#424 publishes rind-ring 0.17.0, so rind-patch's first CI run is red.Models
Size: XS
Implementer: Claude Code, Claude Opus 5.5, high effort
(Written by Claude Opus 5.5 with high)
🤖 Generated with Claude Code
Review
Rewritten by
quest reviewafter each round.01a1b4bd-51d0-7cf2-88e5-0bb3f0e1f315, round 1No actionable defects were found in the specified diff; cached external shim manifests confirm the intended dependency wiring and shell syntax checks passed, though build tests were not run in the read-only environment.