Skip to content

chore: set rind to 0.3.3 so its next release is not breaking - #512

Merged
kixelated merged 1 commit into
mainfrom
chore/rind-0.3.3
Nov 9, 2026
Merged

kixelated merged 1 commit into
mainfrom
chore/rind-0.3.3

Conversation

@kixelated

@kixelated kixelated commented Nov 9, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

The open release PR, moq-dev/rind#511, proposes rind 0.3.2 → 0.4.0, even though cargo-semver-checks reports rind's API unchanged.
The only commit since 0.3.2 is moq-dev/rind#510 (chore!: delete rind-instant-acme). release-plz counts it against rind because rind/README.md is a symlink to the root README, which that PR edited. The ! then forces a breaking minor bump. release-plz will keep proposing 0.4.0 until the version is set by hand.

Approach

Set rind's version to 0.3.3 by hand. Per CONTRIBUTING.md's Releases section, release-plz keeps a hand-set version that is ahead of the published one, so the next release PR publishes 0.3.3. The adapters' rind = "0.3.2" requirements already accept 0.3.3.

Impact

  • No public API or wire change. rind's next release is a patch, so no consumer has to move to a new minor and no graph ends up with two copies of rind.

Alternatives

  • Release 0.4.0 as proposed: that would force every direct rind user onto a new minor for a README edit.

Checks

  • quest gate just check origin/main passed.

Models

Size: XS
Implementer: Claude Code, claude-opus-5-5, high effort

(Written by Claude Opus 5.5 with high)

🤖 Generated with Claude Code

Review

Rewritten by quest review after each round.

  • Reviewer: Codex, gpt-6.1-sol, low effort
  • Session: 01a1bde5-83bc-7022-9bd3-920a4a37a8a1, round 1
  • Head: 6cf92d1
  • Base: origin/main at b295b31
  • Score: 10/10, The change consistently bumps rind from 0.3.2 to 0.3.3 in its manifest and lockfile without changing cryptographic paths or behavior.
  • Findings: none

Release verification: .release-plz.toml keeps release_always = false; CONTRIBUTING.md Releases and release-plz documentation confirm a local version ahead of the registry is retained. Thus the next release PR retains 0.3.3 instead of recomputing 0.4.0. All adapter requirements 0.3.2 accept 0.3.3; Cargo.lock already matches. No additional changes or follow-ups needed.

Standing pick: /quest-merge.

(Written by GPT-6.1 Sol with low)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review November 9, 2026 04:35

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • rind 0.3.2 → 0.3.3 hand-set bump: rind/Cargo.toml and the matching Cargo.lock entry move to 0.3.3 so release-plz stops proposing 0.4.0 for a README-only change; no code, API, or dependency changes.

Verified the PR's load-bearing claims directly:

  • cargo metadata --offline passes, so Cargo.lock is consistent with the manifests (the remaining 0.3.2 strings in the lock belong to other packages).
  • Every adapter requirement is rind = { version = "0.3.2", path = "../rind" }, which under caret semantics accepts 0.3.3, so nothing else needs to move.
  • CONTRIBUTING.md's Releases section documents this exact procedure: "A version set by hand ahead of the published one is kept as is, and the next release PR publishes it." .release-plz.toml keeps release_always = false, so publishing still happens only on a merged release PR.
  • rind/CHANGELOG.md needs no hand edit here — release-plz generates the 0.3.3 entry in the next release PR, and the existing 0.3.2 heading is history.

Pullfrog  | View workflow run | Using glm-5.3 | 𝕏

@coderabbitai

coderabbitai Bot commented Nov 9, 2026

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The rind package version in Cargo.toml changes from 0.3.2 to 0.3.3.

Merge Risk: Minimal · up to 6cf92

The patch version remains compatible with existing adapter requirements, and the release tooling supports retaining the manually selected version. This change is ready to merge after normal checks.

Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed The title states the main change: rind is set to version 0.3.3 so its next release is not breaking. The changeset bumps rind's version from 0.3.2 to 0.3.3 in rind/Cargo.toml, which matches the title. …
Description check Passed The description explains the problem, the approach, the impact, and the alternatives. It describes the version bump to 0.3.3 in rind, the release-plz behavior that motivated it, and the adapter requir…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title states the main change: rind is set to version 0.3.3 so its next release is not breaking. The changeset bumps rind's version from 0.3.2 to 0.3.3 in rind/Cargo.toml, which matches the title. The title uses the 'chore:' prefix, which is a conventional commit style and does not affect the assessment.

Full details: Description check

Explanation

The description explains the problem, the approach, the impact, and the alternatives. It describes the version bump to 0.3.3 in rind, the release-plz behavior that motivated it, and the adapter requirements that accept 0.3.3. This relates directly to the Cargo.toml version change in the changeset.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches

Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c84d6d14-33b7-48a6-b7d9-dcdb2655f63d
Commits

Reviewing files that changed from the base of the PR and between b295b31 and 6cf92d1.

Files ignored due to path filters: 1

  • Cargo.lock is excluded by !**/*.lock
Files selected for processing: 1

  • rind/Cargo.toml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@kixelated
kixelated added this pull request to the merge queue Nov 9, 2026
Merged via the queue into main with commit 7af3a61 Nov 9, 2026
17 checks passed
@moq-bot moq-bot Bot mentioned this pull request Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant