[skjnldsv]

The library runs on Nextcloud 35 next to the viewer app, but nothing said what that means. Checked on 35.0.2 with an app bundling the library: pictures, videos and sounds open in the library's viewer, from the app and from Files. The handlers other apps register with OCA.Viewer, HEIC and TIFF previews, and saved settings are not there. So the viewer hides its settings there: no button, and ? does nothing.

The README gets a "Nextcloud 35 and older" section with that list. The viewer logs a warning when it mounts on such a server, found by the viewer app's OCA.Viewer.registerHandler (the shim of 36 has none) or by OC.config.version.

Only images, video and audio were checked.

👾 This pull request was assisted by Claude Code, commits carry an Assisted-by trailer.

[codecov]

Codecov Report

❌ Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.44%. Comparing base (4e2c04a) to head (4f61388).

Files with missing lines	Patch %	Lines
lib/mount.ts	25.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
+ Coverage   92.42%   92.44%   +0.02%     
==========================================
  Files          49       50       +1     
  Lines        4103     4119      +16     
  Branches      898      903       +5     
==========================================
+ Hits         3792     3808      +16     
+ Misses        290      289       -1     
- Partials       21       22       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[AndyScherzinger]

Thanks for documenting this! 🙏

files_mindmap registers its handler with this library and supports Nextcloud 32–36 from one release (nextcloud/files_mindmap#375). On 32–35 that means the library runs next to the viewer app, so every page that loads our init script will log this warning, even though there is no other way to support those versions from the same code. What's the recommended approach for apps that span 32–36? Should we register with the library only on 36+ and keep OCA.Viewer.registerHandler() on older servers, or is the warning fine to ignore?

[skjnldsv]

Hey Andy! OCA.Viewer.registerHandler is unfortunately not used anymore. The handlers behaviour is just too different and it's a breaking change.
We did keep the open/compare from OCA as a transition API, but registerHandler is unfortunately not portable.

I suggest a hard min-supported=36, this is easier that way :)

[skjnldsv]

To add slightly more details, there is two type of viewer consummers:

• Usual file viewing experience
• Adding a dedicated handler

For the first one, it's very easy, we support both the old and the new. We kept OCA.Viewer.open... etc etc
But for a full feature support, I suggest you keep using OCA.Viewer.open for versions under 36, and this lib getViewer().open for 36 and above. This PR is really about people that use getViewer().open on 35 and below, where no handlers besides the shipped ones will be available then.

For the second point, well, this lib is 36 only for new handlers unfortunately.

[AndyScherzinger]

Alright, than I suppose I split it that way going for 36+

Thanks for the quick reply 👍