Repository navigation
chore: release 0.2.0-beta.1 for Nextcloud 36 - #390
Merged
Merged
Conversation
The handler is registered with @nextcloud/viewer, which is made for Nextcloud 36. On older servers it runs next to the viewer app, which the library documents as not a supported setup. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
With Nextcloud 36 as the minimum, the viewer always registers the Files actions for the handler, so the action for Files 32 and its @mdi/svg icon are no longer used. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
1 task done
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the version to 0.2.0-beta.1 and makes Nextcloud 36 both the minimum and maximum version.
Since #375 the handler is registered with
@nextcloud/viewer, which is made for Nextcloud 36, where the server ships the library and the viewer app is gone. On 32–35 it runs next to the old viewer app. That works in our tests (open, save and public share pass on 32, 34 and 36), but the library documents two viewers on one page as not a supported setup and logs a warning about it from its next release (nextcloud-libraries/nextcloud-viewer#148). Requiring 36 keeps this app on the supported path.With 36 as the minimum, the action for Files 32 (from #389) is dead code: the viewer always registers the Files actions for its handlers. It is removed, together with its test and the
@mdi/svgdependency that only provided its icon.Notes:
min-versionand falls back to servermasterwhile no 36 release exists.🤖 AI (if applicable)