Skip to content

[stable-0.1] fix(editor): place node text in Firefox where Chrome places it - #464

Merged
AndyScherzinger merged 1 commit into
stable-0.1from
backport/firefox-text-position/stable-0.1
Oct 27, 2026
Merged

AndyScherzinger merged 1 commit into
stable-0.1from
backport/firefox-text-position/stable-0.1

Conversation

@AndyScherzinger

Copy link
Copy Markdown
Member

Backport of #463, cherry-picked unchanged: the vendored kityminder-core is identical on this line.

In Firefox, node text sat too high in its box (most visibly on Linux, and on Windows for Arial and Times New Roman nodes) because Firefox still used outdated per-browser text offsets. It now uses Chrome's, so text is placed the same in both browsers. Details and checks in #463.

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

The mind map nudges each node's text up or down by a fraction of the
font size, taken from a table per browser and operating system that
was measured years ago. Current Firefox lays out the text like Chrome,
but still used its own outdated values: on Linux the text sat about a
sixth of a line too high, and on Windows text in Arial or Times New
Roman sat a few pixels too high.

Firefox now uses Chrome's values, so text is placed the same in both
browsers. Exports to PNG, SVG and PDF reuse the same text and follow
along.

Assisted-by: Claude Code:claude-opus-5-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
(cherry picked from commit c00fb03)
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger added this to the v0.1.6 milestone Oct 27, 2026
@AndyScherzinger AndyScherzinger added bug Something isn't working AI assisted This PR contains AI-assisted commits 3. to review browser: firefox labels Oct 27, 2026
@AndyScherzinger
AndyScherzinger merged commit 276cc38 into stable-0.1 Oct 27, 2026
7 checks passed
@AndyScherzinger
AndyScherzinger deleted the backport/firefox-text-position/stable-0.1 branch October 27, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review AI assisted This PR contains AI-assisted commits browser: firefox bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant