Repository navigation
Fix CI: VS 2026 generator on windows-11-arm, raw string literals in tests - #5575
Merged
Merged
Conversation
…tests The windows-11-arm runner image moved to windows-11-vs2026-arm64, which no longer ships Visual Studio 2022, so the msvc-arm64 job failed at configure time. Use the "Visual Studio 18 2026" generator like the msvc2026 job. clang-tidy's modernize-raw-string-literal check flagged two string literals in the nesting tests added by #5546 and #5547. Signed-off-by: Niels Lohmann <mail@nlohmann.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two CI failures on
developthat currently break every open PR:windows-11-armlabel now resolves to thewindows-11-vs2026-arm64image, which has no Visual Studio 2022 (could not find any instance of Visual Studio). The job now uses theVisual Studio 18 2026generator, as themsvc2026job already does.modernize-raw-string-literalflagged two literals intests/src/unit-merge_patch.cppandtests/src/unit-modifiers.cpp(added in Hash deeply nested values without recursing per nesting level #5546/Merge deeply nested objects without recursing per nesting level #5547). They are now raw string literals.Breaking changes
None. Only the CI workflow and two unit tests change; the library's public API is untouched.
🤖 Generated with Claude Code