Skip to content

fix: Syntax highlighting broken for bare string values in records #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fdncred merged 5 commits into from
Aug 11, 2026
Merged

fix: Syntax highlighting broken for bare string values in records #237

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
394488f
fix: bound record values so they are not parsed as commands
mst-mkt Aug 2, 2026
ed8ec9a
fix: treat keywords and operators in record values as strings
mst-mkt Aug 2, 2026
84b0b1a
fix: match bare record keys with any character nushell allows
mst-mkt Aug 2, 2026
e113e31
fix: add a comment explaining why the bare key rule excludes datetimes
mst-mkt Aug 11, 2026
c03003d
fix: require a full time part in the datetime lookahead for bare keys
mst-mkt Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 42 additions & 16 deletions syntaxes/nushell.tmLanguage.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,51 +550,63 @@
"patterns": [{ "include": "#function-parameter" }]
},
{
"match": "(\\w+)\\s*(:)\\s*",
"captures": {
"1": { "name": "variable.other.nushell" },
"comment": "Blocks and closures are also scanned by this rule, so the negative lookahead keeps a datetime like 2024-01-01T00:00:00Z from being split into key and value.",
"begin": "(?!\\d{4}-\\d{2}-\\d{2}T\\d{2}:\\d{2}:\\d{2})([^\\s:,|;(){}\\[\"'$#][^\\s:,|;(){}\\[\"']*)\\s*(:)\\s*",
"beginCaptures": {
"1": { "name": "string.bare.nushell variable.other.nushell" },
"2": { "name": "keyword.control.nushell" }
}
},
"end": "(?=[,}])|(?<=[^\\s:])(?=\\s)",
"name": "meta.record-entry.nushell",
"patterns": [{ "include": "#record-value" }]
},
{
"match": "(\\$\"((?:[^\"\\\\]|\\\\.)*)\")\\s*(:)\\s*",
"captures": {
"begin": "(\\$\"((?:[^\"\\\\]|\\\\.)*)\")\\s*(:)\\s*",
"beginCaptures": {
"1": { "name": "variable.other.nushell" },
"2": {
"name": "variable.other.nushell",
"patterns": [{ "include": "#paren-expression" }]
},
"3": { "name": "keyword.control.nushell" }
},
"name": "meta.record-entry.nushell"
"end": "(?=[,}])|(?<=[^\\s:])(?=\\s)",
"name": "meta.record-entry.nushell",
"patterns": [{ "include": "#record-value" }]
},
{
"match": "(\"(?:[^\"\\\\]|\\\\.)*\")\\s*(:)\\s*",
"captures": {
"begin": "(\"(?:[^\"\\\\]|\\\\.)*\")\\s*(:)\\s*",
"beginCaptures": {
"1": { "name": "string.quoted.double.nushell variable.other.nushell" },
"2": { "name": "keyword.control.nushell" }
},
"name": "meta.record-entry.nushell"
"end": "(?=[,}])|(?<=[^\\s:])(?=\\s)",
"name": "meta.record-entry.nushell",
"patterns": [{ "include": "#record-value" }]
},
{
"match": "(\\$'([^']*)')\\s*(:)\\s*",
"captures": {
"begin": "(\\$'([^']*)')\\s*(:)\\s*",
"beginCaptures": {
"1": { "name": "variable.other.nushell" },
"2": {
"name": "variable.other.nushell",
"patterns": [{ "include": "#paren-expression" }]
},
"3": { "name": "keyword.control.nushell" }
},
"name": "meta.record-entry.nushell"
"end": "(?=[,}])|(?<=[^\\s:])(?=\\s)",
"name": "meta.record-entry.nushell",
"patterns": [{ "include": "#record-value" }]
},
{
"match": "('[^']*')\\s*(:)\\s*",
"captures": {
"begin": "('[^']*')\\s*(:)\\s*",
"beginCaptures": {
"1": { "name": "string.quoted.single.nushell variable.other.nushell" },
"2": { "name": "keyword.control.nushell" }
},
"name": "meta.record-entry.nushell"
"end": "(?=[,}])|(?<=[^\\s:])(?=\\s)",
"name": "meta.record-entry.nushell",
"patterns": [{ "include": "#record-value" }]
},
{ "include": "#spread" },
{ "include": "source.nushell" }
Expand Down Expand Up @@ -718,6 +730,20 @@
{ "include": "#string" },
{ "include": "#comment" }
]
},
"record-value": {
"patterns": [
{ "include": "#variables" },
{ "include": "#variable-fields" },
{ "include": "#constant-value" },
{ "include": "#table" },
{ "include": "#spread" },
{ "include": "#ranges" },
{ "include": "#paren-expression" },
{ "include": "#braced-expression" },
{ "include": "#string" },
{ "include": "#comment" }
]
}
}
}
Loading