Repository navigation
Conversation
commit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Strapi 5 dynamic-zone queries using
populate: { sections: { on: { 'sections.hero': { populate: ['image'] } } } }currently fail typechecking because the populate types do not acceptonfragments.Add fragment support for dynamic-zone arrays, deriving component names from the
__componentdiscriminator and checking each fragment against its matching component type. Existing populate forms remain valid, and runtime request handling is unchanged.Fixes #505.
Compile-time regression tests cover the reported hero/gallery query, partial component selection, nested population, fragment query options, and existing populate syntaxes. Negative cases reject unknown component names, fields from the wrong component, and fragments on ordinary relations. These tests run through the existing CI
typecheckstep. The reported query was confirmed to fail before the type change.Validation
pnpm install --frozen-lockfilepnpm run dev:preparepnpm run lintpnpm run typecheckpnpm run test— 43 tests passed, including the Nuxt end-to-end test.pnpm run buildChecklist
Documentation changes are not required: this corrects the types for existing Strapi query syntax.