Repository navigation
chore: enforce generated-file ownership - #3061
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a34375ea25
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Castiron-Internal-PR: openai/openai-node-internal#400 Castiron-Source-SHA: d7a4bc8b719b8dfe03d9b5ac38f6321e7e0aa23a Castiron-Public-Base-SHA: 4e95fe2
jbeckwith-oai
changed the title
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dd4d4a301a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Fixed the current-head Node 22/24/26 test failure in dd05581. The existing public-command fixture copied |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 982dbad88d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Policy update in 982dbad, following the repository owner's explicit direction: generated-file ownership relies on AGENTS.md and ordinary code review for now. Removed the proposed checksum/mode checker and its CI invocation, and updated contributor/security guidance accordingly. There is no dedicated generated-file edit gate in this rollout. The retired budget requirements are absent from the live rulesets and the old reporting workflows are disabled; normal SDK tests, security checks, CODEOWNER review and generation provenance remain. Requests to add a replacement generated-edit enforcement path are superseded by this policy decision. Monitoring the new CI head. |
markstuart-oai
left a comment
markstuart-oai
left a comment
There was a problem hiding this comment.
Reviewed fbc59a2070fad754ce512d4447a1cf2262fff2d3 against 4e95fe2bd074edf5337406b28b111141fb3c245a, including the final removal of the proposed generated-file checker. No actionable findings after source review and an independent incremental pass.
The retired budget tooling and its consumers are removed together. The final guidance explicitly relies on contributor instructions and ordinary code review, with no dedicated generated-edit gate. Existing lint/test entry points are preserved.
Validation: current-head lint, build, ecosystem checks and Node 26 tests passed; Node 22 and 24 tests were still running. No candidate code, tests or generation ran locally. I did not independently verify the author-reported live ruleset changes.
|
@codex review Please refresh the code review for current head fbc59a2; the existing summary covers the previous revision. Review the current implementation and resolved feedback. The generated-file ownership rollout explicitly relies on AGENTS.md and normal code review for now, without replacement generated-file edit enforcement. |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Post-merge Dependabot diagnosis: runs40561906182 and40561905614 report security_update_not_possible while trying to update the existing dependency graphs in the repository root and ecosystem-tests/ts-browser-webpack. Compared the parent of merge e7afc14 with the merge itself: root package.json, pnpm-lock.yaml, .github/dependabot.yml, and the webpack fixture's package.json/package-lock.json are all unchanged. These are dependency-maintenance failures requiring a separate compatible upgrade. No dependency versions or security controls were changed by this rollout. |
Retire generated-file customization budgets and rely on
AGENTS.md, contributor guidance, and ordinary code review for ownership. Generated files must not carry handwritten edits: fix the inputs/compiler and regenerate; put custom behavior in separately owned handwritten extensions.This combines normal Castiron-regenerated cleanup with SDK-owned documentation. It removes the budget reporters, workflows, zero-only policy, and the proposed dedicated file checker. There is no dedicated generated-file edit gate for now. The compiler replaces generated output and deletes retired paths without three-way replay.
The retired budget status requirements are removed and their producers disabled across public/private SDKs. Normal SDK checks, CODEOWNER review, generation/promotion provenance, and release pins remain. Generated output and inventory changes should be reviewed together.
Validation: documentation and workflow diffs checked; the unchanged generated output still matches normal generation. Relevant formatting and focused entrypoint/layout tests pass. Two consecutive independent review rounds and current-head CI are tracked for this revision.