Skip to content

fix(scheduler): keep due checks tied to exact job and repo - #245

Merged
vincentkoc merged 1 commit into
mainfrom
fix/run-history-identity
Nov 16, 2026
Merged

vincentkoc merged 1 commit into
mainfrom
fix/run-history-identity

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

What Problem This Solves

The runner can skip a due job or rerun a recently successful job when different job/repository pairs share a colon-joined history key. For example, job sync:other collides with job sync in repository other.

User Impact

Automatic due checks use each exact job and repository's history, preserving independent schedules even when names contain colons.

Why This Change Was Made

Use structured identity keys inside the runner. The public history map, stored JSON records, interval rules, and explicit job execution behavior remain unchanged.

Evidence

  • All six end-to-end regression cases fail before the fix and pass afterward: direct/repository collisions in both directions, plus colons inside repository names; each covers false skips and false reruns.
  • Existing not-due control, full uncached Go suite, vet, module tidiness, formatting, and diff checks pass with GOWORK=off.
  • Tests use temporary data and the Go test executable without platform-specific shell fixtures.
  • Independent native P0–P3 review found no actionable findings in complete candidate b0fe80909158ae5ce8e8bbec48c7d69565703a35 against base 3853f24e96503325e6bd93b5b63c8d68d9b0142e. Scope: full diff, unchanged runner, due checks, expansion, and history context; read-only isolated review.

@clawsweeper

clawsweeper Bot commented Nov 16, 2026

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

@vincentkoc
vincentkoc marked this pull request as ready for review November 16, 2026 02:51
@vincentkoc
vincentkoc merged commit f156a28 into main Nov 16, 2026
8 checks passed
@vincentkoc
vincentkoc deleted the fix/run-history-identity branch November 16, 2026 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant