Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs real behavior proof before merge. Reviewed October 3, 2026, 3:51 AM ET / 07:51 UTC (Revision 5). ClawSweeper reviewWhat this changesAdds a draft proposal for displaying installed-plugin update availability in CLI inventory, update status, and Control UI using explicit refresh and shared retained observations. Merge readiness⛔ Blocked before merge - 3 items remain Keep open: this is a coherent, distinct RFC absent from current main. Maintainer acceptance and the previously requested document-verification evidence remain outstanding. Priority: P3 Review scores
Verification
How this fits togetherThis repository records OpenClaw design proposals before implementation. The proposed availability owner would compare recorded plugin installations with registry metadata and provide consistent results to CLI and Control UI displays. flowchart LR
A[Recorded plugin installations] --> C[Explicit metadata refresh]
B[Registry metadata] --> C
C --> D[Source and pin comparison]
D --> E[Retained availability observations]
E --> F[CLI inventory and status]
E --> G[Control UI notices]
Decision needed
Why: The repository requires acceptance, and the proposed refresh defaults and persistence ownership are explicitly awaiting maintainer intent. Before merge
Agent review detailsSecurityNone. Review metricsNone. Technical reviewBest possible solution: Accept a single metadata-only availability contract that preserves source and pin choices, makes stale and unknown results explicit, and keeps upgrade-safety assessment separate. Do we have a high-confidence way to reproduce the issue? Not applicable: the branch proposes future behavior and introduces no executable bug fix. Is this the best way to solve the issue? Unclear pending acceptance: reusing metadata-only resolution is a maintainable direction, but the refresh interface and retained-observation contract need an explicit product decision. AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning medium; reviewed against 967d9aac7472. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (4 earlier review cycles)
|
What Problem This Solves
Formalizes Erick Kinnee's proposal to surface installed-plugin update availability in CLI inventory, update status, and Control UI.
Related: openclaw/openclaw#131897
Why This Change Was Made
Proposes ClawHub as the primary metadata path while preserving recorded npm sources. Defines explicit plugin refresh, shared SQLite observation ownership, 24-hour freshness, four concurrent lookups, a 15-second network budget, and JSON distinctions for eligible, excluded, stale, and unknown results. Core upgrades invalidate cached eligibility. Metadata checks must not enter installer dry-run paths.
These defaults and persistence semantics are proposed for maintainer acceptance. Exact schema, migration, and publication fencing require storage-owner review before implementation. Upgrade preflight remains separate: openclaw/openclaw#122019.
User Impact
Proposal only; no runtime behavior changes. If accepted and implemented, operators could discover plugin updates while preserving pins and distinguishing incomplete checks.
Evidence
The required maintainer-discussion thread and RFC acceptance remain outstanding. A maintainer sponsor is needed to advance that discussion.